Issue 5313 - Make error reporting more robust.

chrome/content/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 290 matching lines @@
     let selectors = [];
     if (match.index > 0)
       selectors.push(new PlainSelector(selector.substr(0, match.index)));
 
     let startIndex = match.index + match[0].length;
     let content = parseSelectorContent(selector, startIndex);
     if (!content)
     {
       this.window.console.error(
         new SyntaxError("Failed to parse Adblock Plus " +
-                        `selector ${selector}, ` +

[Wladimir Palant, 2017/06/19 11:22:37]

Nit: There should be no comma here, I vaguely remember noting that in the
previous review.

[hub, 2017/06/19 13:24:42]

Done.

+                        `selector ${selector} ` +
                         "due to unmatched parentheses."));
       return null;
     }
     if (match[1] == "properties")
       selectors.push(new PropsSelector(content.text));
     else if (match[1] == "has")
     {
       let hasSelectors = this.parseSelector(content.text);
       if (hasSelectors == null)
         return null;
-      let hasSelector = new HasSelector(hasSelectors);
-      selectors.push(hasSelector);

[Wladimir Palant, 2017/06/19 11:22:37]

Nit: The temporary hasSelector variable no longer has a point, just push the
instance directly like for PropsSelector.

[hub, 2017/06/19 13:24:42]

Done.

+      selectors.push(new HasSelector(hasSelectors));
     }
     else
     {
       // this is an error, can't parse selector.
       this.window.console.error(
         new SyntaxError("Failed to parse Adblock Plus " +
                         `selector ${selector}, invalid ` +
                         `pseudo-class :-abp-${match[1]}().`));
       return null;
     }
@@ skipping 84 matching lines @@
 
       if (this.patterns.length > 0)
       {
         let {document} = this.window;
         this.addSelectors(document.styleSheets);
         document.addEventListener("load", this.onLoad.bind(this), true);
       }
     });
   }
 };