Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29465555: Issue 5260 - Implement underline formatting to Korean (Closed)

Created:
June 14, 2017, 9:37 a.m. by jens
Modified:
July 4, 2017, 8:21 a.m.
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5260 - Implement underline formatting to Korean

Patch Set 1 : underline instead of quotation marks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M adblockplussbrowser/res/values-ko/strings.xml View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
jens
June 14, 2017, 9:41 a.m. (2017-06-14 09:41:43 UTC) #1
anton
On 2017/06/14 09:41:43, jens wrote: LGTM
June 26, 2017, 1:17 p.m. (2017-06-26 13:17:52 UTC) #2
Felix Dahlke
On 2017/06/26 13:17:52, anton wrote: > On 2017/06/14 09:41:43, jens wrote: > > LGTM NOT ...
June 26, 2017, 1:22 p.m. (2017-06-26 13:22:24 UTC) #3
Felix Dahlke
June 26, 2017, 2:07 p.m. (2017-06-26 14:07:35 UTC) #4
On 2017/06/26 13:22:24, Felix Dahlke wrote:
> On 2017/06/26 13:17:52, anton wrote:
> > On 2017/06/14 09:41:43, jens wrote:
> > 
> > LGTM
> 
> NOT LGTM - this seems like a change we made rather than one made by
translators
> and merely applied by us, judging from the comments in issue 5260. I've asked
> Tamara about more information.

Discussed it with Tamara, we are not on Crowdin yet with ABP for SBrowser, so
LGTM.

Powered by Google App Engine
This is Rietveld