Issue 5309 - Subscriptions update causes ANR

libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 186 matching lines @@
     {
       androidWebRequest = new AndroidWebRequest(engine.elemhideEnabled, true);
       engine.webRequest = androidWebRequest;
 
       if (urlToResourceIdMap != null)
       {
         AndroidWebRequestResourceWrapper wrapper = new AndroidWebRequestResourceWrapper(
           context, engine.webRequest, urlToResourceIdMap, resourceStorage);
         wrapper.setListener(new AndroidWebRequestResourceWrapper.Listener()
         {
-          private AdblockEngine adblockEngine;
-
-          AndroidWebRequestResourceWrapper.Listener init(AdblockEngine adblockEngine)
-          {
-            this.adblockEngine = adblockEngine;
-            return this;
-          }
-
           @Override
           public void onIntercepted(String url, int resourceId)
           {
-            Log.d(TAG, "Force subscription update");

[anton, 2017/06/15 05:51:53]

previously we invoked updateSubscriptions 1 time for all subsriptions, now we do
it for every single subscription. Since it would be good to output subscription
url in log, smth like this:

`Log.e(TAG, "Force subscription update for " + url)`

[sergei, 2017/06/16 11:12:09]

OK, but why error (Log.e)?

[anton, 2017/06/16 11:25:12]

Yes, obviously not `.e`. My bad.

-            if (this.adblockEngine.filterEngine != null)

[anton, 2017/06/15 05:51:53]

"{" required

[sergei, 2017/06/16 11:12:09]

Done.

-              this.adblockEngine.filterEngine.updateFiltersAsync(url);

[anton, 2017/06/15 05:51:53]

"}" required 

[sergei, 2017/06/16 11:12:08]

Done.

+            Log.d(TAG, "Force subscription update for intercepted URL " + url);
+            if (engine.filterEngine != null)
+            {
+              engine.filterEngine.updateFiltersAsync(url);
+            }
           }
-        }.init(this.engine));
+        });
 
         engine.webRequest = wrapper;
       }
     }
 
     private void initCallbacks()
     {
       if (engine.updateAvailableCallback != null)
       {
         engine.filterEngine.setUpdateAvailableCallback(engine.updateAvailableCallback);
@@ skipping 405 matching lines @@
   public void setWhitelistedDomains(List<String> domains)
   {
     this.whitelistedDomains = domains;
   }
 
   public List<String> getWhitelistedDomains()
   {
     return whitelistedDomains;
   }
 }