Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(509)

Issue 29467595: Issue 5325 - Add support for separator characters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by Manish Jethani
Modified:
2 years, 6 months ago
Reviewers:
kzar
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/abp2blocklist
Visibility:
Public.

Description

Issue 5325 - Add support for separator characters

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add special handling for separator at beginning #

Total comments: 13

Patch Set 3 : Wrap long lines #

Patch Set 4 : Add comment about using only lower case for hostname #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -32 lines) Patch
M lib/abp2blocklist.js View 1 2 3 4 1 chunk +20 lines, -2 lines 0 comments Download
M test/abp2blocklist.js View 1 2 3 4 2 chunks +72 lines, -30 lines 0 comments Download

Messages

Total messages: 12
Manish Jethani
2 years, 7 months ago (2017-06-16 17:25:57 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29467595/diff/29467596/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29467595/diff/29467596/lib/abp2blocklist.js#newcode154 lib/abp2blocklist.js:154: regexp.push("([^.%A-Za-z0-9_].*)?$"); Can you put the duplicated part of the ...
2 years, 7 months ago (2017-06-16 21:13:18 UTC) #2
Manish Jethani
Patch Set 2: Add special handling for separator at beginning https://codereview.adblockplus.org/29467595/diff/29467596/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29467595/diff/29467596/lib/abp2blocklist.js#newcode154 ...
2 years, 7 months ago (2017-06-19 10:39:54 UTC) #3
kzar
(Moving Sebastian to Cc.) https://codereview.adblockplus.org/29467595/diff/29468560/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29467595/diff/29468560/lib/abp2blocklist.js#newcode151 lib/abp2blocklist.js:151: let separator = "[^-_.%" + ...
2 years, 6 months ago (2017-07-07 12:46:19 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29467595/diff/29468560/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29467595/diff/29468560/lib/abp2blocklist.js#newcode151 lib/abp2blocklist.js:151: let separator = "[^-_.%" + (justHostname ? "" : ...
2 years, 6 months ago (2017-07-08 06:29:10 UTC) #5
Manish Jethani
https://codereview.adblockplus.org/29467595/diff/29468560/test/abp2blocklist.js File test/abp2blocklist.js (right): https://codereview.adblockplus.org/29467595/diff/29468560/test/abp2blocklist.js#newcode178 test/abp2blocklist.js:178: {trigger: {"url-filter": "^https?://([^/]+\\.)?example\\.com/path([^-_.%A-Za-z0-9].*)?$", On 2017/07/07 12:46:18, kzar wrote: > ...
2 years, 6 months ago (2017-07-08 06:33:57 UTC) #6
Manish Jethani
Patch Set 3: Wrap long lines https://codereview.adblockplus.org/29467595/diff/29468560/test/abp2blocklist.js File test/abp2blocklist.js (right): https://codereview.adblockplus.org/29467595/diff/29468560/test/abp2blocklist.js#newcode178 test/abp2blocklist.js:178: {trigger: {"url-filter": "^https?://([^/]+\\.)?example\\.com/path([^-_.%A-Za-z0-9].*)?$", ...
2 years, 6 months ago (2017-07-09 10:50:53 UTC) #7
kzar
Otherwise LGTM https://codereview.adblockplus.org/29467595/diff/29468560/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29467595/diff/29468560/lib/abp2blocklist.js#newcode151 lib/abp2blocklist.js:151: let separator = "[^-_.%" + (justHostname ? ...
2 years, 6 months ago (2017-07-10 12:39:56 UTC) #8
Manish Jethani
Patch Set 4: Add comment about using only lower case for hostname https://codereview.adblockplus.org/29467595/diff/29468560/lib/abp2blocklist.js File lib/abp2blocklist.js ...
2 years, 6 months ago (2017-07-11 17:10:33 UTC) #9
kzar
LGTM, go ahead and push when you're ready. https://codereview.adblockplus.org/29467595/diff/29468560/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29467595/diff/29468560/lib/abp2blocklist.js#newcode151 lib/abp2blocklist.js:151: let ...
2 years, 6 months ago (2017-07-12 09:16:31 UTC) #10
Manish Jethani
Patch Set 5: Rebase There were some conflicts in the test file, resolved.
2 years, 6 months ago (2017-07-12 12:48:22 UTC) #11
kzar
2 years, 6 months ago (2017-07-12 15:46:45 UTC) #12
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5