Issue 5325 - Add support for separator characters

lib/abp2blocklist.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 131 matching lines @@
     }
 
     switch (c)
     {
       case "*":
         if (regexp.length > 0 && i < lastIndex && text[i + 1] != "*")
           regexp.push(".*");
         break;
       case "^":
         if (i < lastIndex)
-          regexp.push(".");
+          regexp.push("[^.%A-Za-z0-9_]");
+        else
+          regexp.push("([^.%A-Za-z0-9_].*)?$");

[Sebastian Noack, 2017/06/16 21:13:18]

Can you put the duplicated part of the regexp in a variable?

[Manish Jethani, 2017/06/19 10:39:54]

Done.

+        canSafelyMatchAsLowercase = false;

[Sebastian Noack, 2017/06/16 21:13:18]

Why is that necessary?

[Manish Jethani, 2017/06/19 10:39:54]

It was converting "A-Z" into "a-z". I thought about this a little more, it's not
necessary. Instead, we just remove the "A-Z" if the separator occurs at the end
of the hostname.

         break;
       case "|":
         if (i == 0)
         {
           regexp.push("^");
           break;
         }
         if (i == lastIndex)
         {
           regexp.push("$");
@@ skipping 376 matching lines @@
   {
     convertFilterAddRules(rules, filter, "block", true,
                           requestFilterExceptionDomains);
   }
 
   for (let filter of this.requestExceptions)
     convertFilterAddRules(rules, filter, "ignore-previous-rules", true);
 
   return rules.filter(rule => !hasNonASCI(rule));
 };