Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/abp2blocklist.js

Issue 29467595: Issue 5325 - Add support for separator characters (Closed) Base URL: https://hg.adblockplus.org/abp2blocklist
Patch Set: Add comment about using only lower case for hostname Created July 11, 2017, 5:06 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/abp2blocklist.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/abp2blocklist.js
===================================================================
--- a/lib/abp2blocklist.js
+++ b/lib/abp2blocklist.js
@@ -143,18 +143,36 @@
switch (c)
{
case "*":
if (regexp.length > 0 && i < lastIndex && text[i + 1] != "*")
regexp.push(".*");
break;
case "^":
- if (i < lastIndex)
- regexp.push(".");
+ let alphabet = "a-z";
+ // If justHostname is true and we've encountered a "^", it means we're
+ // still in the hostname part of the URL. Since hostnames are always
+ // lower case (Punycode), there's no need to include "A-Z" in the
+ // pattern. Further, subsequent code may lower-case the entire regular
+ // expression (if the URL contains only the hostname part), leaving us
+ // with "a-za-z", which would be redundant.
+ if (!justHostname)
+ alphabet = "A-Z" + alphabet;
+ let digits = "0-9";
+ // Note that the "-" must appear first here in order to retain its
+ // literal meaning within the brackets.
+ let specialCharacters = "-_.%";
+ let separator = "[^" + specialCharacters + alphabet + digits + "]";
+ if (i == 0)
+ regexp.push("^https?://(.*" + separator + ")?");
+ else if (i == lastIndex)
+ regexp.push("(" + separator + ".*)?$");
+ else
+ regexp.push(separator);
break;
case "|":
if (i == 0)
{
regexp.push("^");
break;
}
if (i == lastIndex)
« no previous file with comments | « no previous file | test/abp2blocklist.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld