Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(393)

Issue 29468575: Issue 5332 - Support Unicode characters in path (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by Manish Jethani
Modified:
2 years, 6 months ago
Reviewers:
kzar
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/abp2blocklist
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add comment about Unicode surrogate pairs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M lib/abp2blocklist.js View 1 2 chunks +17 lines, -8 lines 0 comments Download
M test/abp2blocklist.js View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5
Manish Jethani
2 years, 7 months ago (2017-06-19 14:35:48 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29468575/diff/29468576/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29468575/diff/29468576/lib/abp2blocklist.js#newcode112 lib/abp2blocklist.js:112: let characters = Array.from(text); We just ...
2 years, 7 months ago (2017-06-19 14:41:06 UTC) #2
kzar
(Moving Sebastian to Cc.) Except for adding that comment this LGTM. https://codereview.adblockplus.org/29468575/diff/29468576/lib/abp2blocklist.js File lib/abp2blocklist.js (right): ...
2 years, 6 months ago (2017-07-07 12:18:07 UTC) #3
Manish Jethani
Patch Set 2: Add comment about Unicode surrogate pairs https://codereview.adblockplus.org/29468575/diff/29468576/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29468575/diff/29468576/lib/abp2blocklist.js#newcode112 lib/abp2blocklist.js:112: ...
2 years, 6 months ago (2017-07-08 06:02:20 UTC) #4
kzar
2 years, 6 months ago (2017-07-10 12:13:51 UTC) #5
LGTM

(Go ahead and push this when you're ready, this one doesn't need Sebastian to
double-check.)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5