Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(330)

Issue 29468579: Issue 5332 - Do not filter out rules containing non-ASCII characters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by Manish Jethani
Modified:
2 years, 6 months ago
Reviewers:
kzar
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/abp2blocklist
Visibility:
Public.

Description

Issue 5332 - Do not filter out rules containing non-ASCII characters

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -27 lines) Patch
M lib/abp2blocklist.js View 2 chunks +1 line, -25 lines 0 comments Download
M test/abp2blocklist.js View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 3
Manish Jethani
2 years, 7 months ago (2017-06-19 16:10:01 UTC) #1
Manish Jethani
Patch Set 1 There's no need to filter out non-ASCII characters here as Safari supports ...
2 years, 7 months ago (2017-06-19 16:12:16 UTC) #2
kzar
2 years, 6 months ago (2017-07-07 12:19:30 UTC) #3
(Moving Sebastian to Cc.)

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5