Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: includes/meta/social.tmpl

Issue 29469558: Issue 5329 - Optimize website-boilerplate for sharing on social media networks (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Added og:type Created June 20, 2017, 3:08 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | includes/meta/standard.tmpl » ('j') | includes/meta/standard.tmpl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 {#
juliandoucette 2017/06/21 12:05:01 Does fb:app_id apply to pages?
ire 2017/06/21 13:20:24 Sorry I think I was unclear with my use of "page".
2 # This file is part of the website-defaults,
3 # Copyright (C) 2017 eyeo GmbH
4 #
5 # website-defaults is free software: you can redistribute it and/or modify
6 # it under the terms of the GNU General Public License version 3 as
7 # published by the Free Software Foundation.
8 #
9 # website-defaults is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
13 #
14 # You should have received a copy of the GNU General Public License
15 # along with website-defaults. If not, see <http://www.gnu.org/licenses/>.
16 #
17 # ---
18 #
19 # # Essential meta data for sharing on social media
ire 2017/06/21 11:39:29 This list in the comments isn't representative of
juliandoucette 2017/06/21 12:05:00 I excluded fields that I automated (e.g.locale).
20 #
21 # og:type
22 # : Page type (e.g. website, article)
23 #
24 # og:site
ire 2017/06/21 11:39:29 This should be og:site_name
juliandoucette 2017/06/21 12:05:01 Done. Good catch.
25 # : A short name associated with the site (not page)
26 #
27 # twitter:site
28 # : A twitter username associated with the site (not page)
29 #
ire 2017/06/21 11:39:29 NIT: Can you group the `og` and the `twitter` meta
juliandoucette 2017/06/21 12:05:01 Acknowledged. I grouped them categorically. e.g.
juliandoucette 2017/06/21 12:24:16 Done.
30 # og:title
31 # : A clear title without branding or mentioning the domain itself
32 #
33 # og:description
34 # : A clear description, at least two sentences long
35 #
36 # og:image
37 # : Featured image (at least 1200x630, up to 5MB)
38 #}
39 {% if og_type %}
40 <meta property="og:type" content="{{ og_type }}">
41 {% endif %}
42 {% if og_site_name %}
43 <meta property="og:site_name" content="{{ og_site_name }}">
44 {% endif %}
45 {% if twitter_site %}
46 <meta name="twitter:site" content="@{{ twitter_site }}">
47 {% endif %}
juliandoucette 2017/06/21 12:05:01 Note: There is another proprietary field for assoc
48 {% if og_title %}
49 <meta property="og:title" content="{{ og_title }}">
50 {% endif %}
51 {% if og_description %}
52 <meta property="og:descirption" content="{{ og_description }}">
53 {% endif %}
54 {% if og_image %}
55 <meta property="og:image" content="{{ og_image }}">
56 {% else if og_site_image %}
57 <meta property="og:image" content="{{ og_site_image }}">
58 {% endif %}
59 {% if twitter_card %}
60 <meta name="twitter:card" content="{{ twitter_card }}">
61 {% else if og_image or og_site_image %}
62 <meta name="twitter:card" content="summary_large_image">
63 {% else %}
64 <meta name="twitter:card" content="summary">
65 {% endif %}
66 {% if twitter_image_alt %}
67 <meta name="twitter:image:alt" content="{{ twitter_image_alt }}">
68 {% endif %}
ire 2017/06/21 11:39:29 These metadata are missing for twitter cards: twi
juliandoucette 2017/06/21 12:05:00 Falls back to og:image
ire 2017/06/21 13:20:24 Noted.
69 {% if host and page %}
70 <meta property="og:url" content="{{ host }}/{{ page }}">
71 {% endif %}
72 <meta property="og:locale" content="{{ locale }}">
73 {% for alternate_locale in locales %}
74 {% if alternate_locale != locale %}
75 <meta property="og:locale:alternate" content="{{ alternate_locale }}">
76 {% endif %}
77 {% endfor %}
OLDNEW
« no previous file with comments | « no previous file | includes/meta/standard.tmpl » ('j') | includes/meta/standard.tmpl » ('J')

Powered by Google App Engine
This is Rietveld