Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/meta/standard.tmpl

Issue 29469558: Issue 5329 - Optimize website-boilerplate for sharing on social media networks (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set: Removed shortcut icon Created June 20, 2017, 2:42 p.m.
Right Patch Set: Separated open graph and twitter fields Created June 21, 2017, 12:23 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« includes/meta/social.tmpl ('K') | « includes/meta/social.tmpl ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 {# 1 {#
2 # This file is part of the website-defaults, 2 # This file is part of the website-defaults,
3 # Copyright (C) 2017 eyeo GmbH 3 # Copyright (C) 2017 eyeo GmbH
4 # 4 #
5 # website-defaults is free software: you can redistribute it and/or modify 5 # website-defaults is free software: you can redistribute it and/or modify
6 # it under the terms of the GNU General Public License version 3 as 6 # it under the terms of the GNU General Public License version 3 as
7 # published by the Free Software Foundation. 7 # published by the Free Software Foundation.
8 # 8 #
9 # website-defaults is distributed in the hope that it will be useful, 9 # website-defaults is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details. 12 # GNU General Public License for more details.
13 # 13 #
14 # You should have received a copy of the GNU General Public License 14 # You should have received a copy of the GNU General Public License
15 # along with website-defaults. If not, see <http://www.gnu.org/licenses/>. 15 # along with website-defaults. If not, see <http://www.gnu.org/licenses/>.
16 # 16 #
17 # --- 17 # ---
18 # 18 #
19 # # Essential meta data for all websites 19 # # Essential meta data for all websites
20 # 20 #
21 # ## title 21 # ## title
22 # 22 #
23 # Optimal format 23 # Optimal format
24 # : Primary Keeyword - Secondary Keyword | Brand Name 24 # : Primary Keyword - Secondary Keyword | Brand Name
25 # 25 #
26 # Optimal length 26 # Optimal length
27 # : 50-60 characters (600px wide on desktop) 27 # : 50-60 characters (600px wide on desktop)
28 # 28 #
29 # Fallback 29 # Fallback
30 # : First highest level heading 30 # : First highest level heading
31 # 31 #
32 # Nuance 32 # Nuance
33 # : Titles are user facing, therefore it's important that they are readable. 33 # : Titles are user facing, therefore it's important that they are readable.
34 # But they must also be very compact. Full scentences, punctuation, and 34 # But they must also be very compact. Full scentences, punctuation, and
35 # uncommon words are discouraged unless they are specifically targeted. 35 # uncommon words are discouraged unless they are specifically targeted.
36 # 36 #
37 # ## description 37 # ## description
38 # 38 #
39 # Optimal format 39 # Optimal format
40 # : Scentence 40 # : Scentence
41 # 41 #
42 # Optimal length 42 # Optimal length
43 # : Less than 160 characters 43 # : Less than 160 characters
44 # 44 #
45 # Fallback 45 # Fallback
46 # : First 160 characters of phrasing content 46 # : First 160 characters of phrasing content
47 # 47 #
48 # Nuance 48 # Nuance
49 # : Descriptions are no longer directly weighted by popular search engines. 49 # : Descriptions are no longer directly weighted by popular search engines.
50 # A good description introduces a page to encourage a click (which is 50 # A good description introduces a page to encourage a click (which is
51 # directly weighted by popular search engines) in less than 160 characters. 51 # directly weighted by popular search engines) in less than 160 characters.
52 #} 52 #}
53 <meta charset="utf-8"> 53 <meta charset="utf-8">
54 <meta http-equiv="x-ua-compatible" content="ie=edge"> 54 <meta http-equiv="x-ua-compatible" content="ie=edge">
juliandoucette 2017/06/20 14:57:54 Note: We have had discussions about these meta tag
55 <meta name="viewport" content="width=device-width, initial-scale=1"> 55 <meta name="viewport" content="width=device-width, initial-scale=1">
56 {% if title %} 56 {% if title %}
juliandoucette 2017/06/20 14:57:54 Note: I had considered enforcing the optimal forma
57 <title>{{ title | translate("page-title", "Meta page title") }}</title> 57 <title>{{ title | translate("page-title", "Meta page title") }}</title>
58 {% endif %} 58 {% endif %}
59 {% if description %} 59 {% if description %}
60 <meta name="description" content="{{ description | translate("page-description ", "Meta page description") }}"> 60 <meta name="description" content="{{ description | translate("page-description ", "Meta page description") }}">
61 {% endif %} 61 {% endif %}
juliandoucette 2017/06/21 15:28:48 Looks like we're missing alternate links! :O Are
juliandoucette 2017/06/22 18:27:43 In Rietveld only individual people make sense. But
ire 2017/07/04 09:03:00 Should the html5shiv and other IE-related scripts
juliandoucette 2017/07/04 10:05:27 - I think it's a best practice to group link and s
ire 2017/07/04 13:27:50 I think (:P) you're right. I didn't necessarily me
juliandoucette 2017/07/04 14:49:29 In that case: Yes.
LEFTRIGHT

Powered by Google App Engine
This is Rietveld