Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29469562: Issue 5094 - The MutationObserver callback was wrong (Closed)

Created:
June 20, 2017, 2:39 p.m. by hub
Modified:
June 20, 2017, 4:43 p.m.
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 5094 - The MutationObserver callback was wrong

Patch Set 1 #

Patch Set 2 : Better fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M include.preload.js View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5
hub
June 20, 2017, 2:39 p.m. (2017-06-20 14:39:19 UTC) #1
hub
Not sure how I never noticed but the mutationObserver was wrong: it gets a list ...
June 20, 2017, 2:40 p.m. (2017-06-20 14:40:32 UTC) #2
Sebastian Noack
Just remove the argument from doHide() and make it always hide "element" from the outer ...
June 20, 2017, 3:21 p.m. (2017-06-20 15:21:59 UTC) #3
hub
all done. :-/
June 20, 2017, 3:58 p.m. (2017-06-20 15:58:19 UTC) #4
Sebastian Noack
June 20, 2017, 3:58 p.m. (2017-06-20 15:58:51 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld