Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29469594: #1634 - Update file resource syntax in module discourse (Closed)

Created:
June 20, 2017, 4:49 p.m. by f.lopez
Modified:
June 22, 2017, 9:48 a.m.
Reviewers:
mathias
CC:
Fred
Visibility:
Public.

Description

#1634 - Update file resource syntax in module discourse

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment number 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M modules/discourse/manifests/init.pp View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4
f.lopez
June 20, 2017, 4:49 p.m. (2017-06-20 16:49:07 UTC) #1
mathias
https://codereview.adblockplus.org/29469594/diff/29469595/modules/discourse/manifests/init.pp File modules/discourse/manifests/init.pp (right): https://codereview.adblockplus.org/29469594/diff/29469595/modules/discourse/manifests/init.pp#newcode74 modules/discourse/manifests/init.pp:74: mode => '755', Now that we're at it, can't ...
June 20, 2017, 5:04 p.m. (2017-06-20 17:04:15 UTC) #2
f.lopez
June 21, 2017, 10:07 a.m. (2017-06-21 10:07:18 UTC) #3
mathias
June 21, 2017, 2:13 p.m. (2017-06-21 14:13:19 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld