#1634 - Update file resource syntax in module hgweb

modules/hgweb/manifests/init.pp

 # == Class: hgweb
 #
 # A hgweb server setup.
 #
 # === Parameters:
 #
 # [*domain*]
 #   The auhority part of the URL the instance is associated with.
 #
 # [*is_default*]
@@ skipping 48 matching lines @@
     comment => 'hgweb',
     groups => ['www-data'],
     home => '/home/hg',
     managehome => true,
     shell => '/bin/bash',
   }
 
   file {'/home/hg/.ssh':
     ensure => 'directory',
     group => 'hg',
-    mode => 0750,
+    mode => '0750',
     owner => 'hg',
     require => User['hg'],
   }
 
   file {'/home/hg/web':
     ensure => 'directory',
     group => 'hg',
-    mode => 0755,
+    mode => '0755',
     owner => 'hg',
     require => User['hg'],
   }
 
   file {'/home/hg/web/hgaccess':
     ensure => 'directory',
     group => 'hg',
-    mode => 0644,
+    mode => '0644',
     owner => 'hg',
     recurse => true,
     replace => false,
     require => File['/home/hg/web'],
     source => $hgaccess,
   }
 
   file {'/home/hg/web/hgaccess/.hg/hgrc':
     content => template('hgweb/hgrc.erb'),
     group => 'hg',
-    mode => 0644,
+    mode => '0644',
     owner => 'hg',
     require => [
       Class['sitescripts'],
       Exec['hgaccess_init'],
     ],
   }
 
   exec {'hgaccess_init':
     command => 'hg init .',
     creates => '/home/hg/web/hgaccess/.hg',
@@ skipping 27 matching lines @@
       X11Forwarding no
       AllowAgentForwarding no
       GatewayPorts no
       ForceCommand cd ~/web && PYTHONPATH=/opt/sitescripts hg-ssh $HGREPOS
     ',
     order => '99',
     target => 'sshd_config',
   }
 
   file {'/etc/hgweb.ini':
-    mode => 644,
+    mode => '644',

[mathias, 2017/06/20 17:01:44]

Now that we're at it, can't we make it uniform and always use the same notation,
be it with or without leading zero?

     require => Package[$required_packages],
     source => 'puppet:///modules/hgweb/hgweb.ini',
   }
 
   file {'/opt/hgweb.fcgi':
-    mode => 755,
+    mode => '755',
     require => File['/etc/hgweb.ini'],
     source => 'puppet:///modules/hgweb/hgweb.fcgi',
   }
 
   if $::operatingsystem == "Debian" {
     file {'init_script':
       name => '/etc/systemd/system/hgweb.service',
-      mode => 755,
+      mode => '755',
       require => File['/opt/hgweb.fcgi'],
       source => 'puppet:///modules/hgweb/hgweb.service',
     }
   } else {
     file {'init_script':
       name => '/etc/init.d/hgweb',
-      mode => 755,
+      mode => '755',
       require => File['/opt/hgweb.fcgi'],
       source => 'puppet:///modules/hgweb/hgweb.sh',
     }
   }
 
   file {'/home/hg/web/robots.txt':
     group => 'hg',
-    mode => 0644,
+    mode => '0644',
     owner => 'hg',
     require => File['/home/hg/web'],
     source => 'puppet:///modules/hgweb/robots.txt',
   }
 
   service {'hgweb':
     enable => true,
     ensure => 'running',
     hasrestart => true,
     hasstatus => false,
@@ skipping 14 matching lines @@
     content => template('hgweb/nginx.conf.erb'),
     is_default => $is_default,
     global_config => template('hgweb/nginx_global.conf.erb'),
     log => 'access_log_hg',
     private_key => $private_key ? {
       'undef' => undef,
       default => $private_key,
     },
   }
 }