#1634 - Update file resource syntax in module web

modules/web/manifests/server.pp

 class web::server(
     $vhost,
     $repository,
     $certificate = hiera('web::server::certificate', 'undef'),
     $private_key = hiera('web::server::private_key', 'undef'),
     $is_default = false,
     $aliases = undef,
     $custom_config = undef,
     $multiplexer_locations = undef,
     $geoip = false,
 ) {
 
   include sitescripts
 
   $pythonpath = 'PYTHONPATH=/opt/cms:/opt/sitescripts'
 
   # Ensure there is at least one character in the respective strings;
   # see https://codereview.adblockplus.org/29329028/#msg3
   validate_re($vhost, '.+')
   validate_re($repository, '.+')
 
   File {
     owner  => 'root',
     group  => 'root',
-    mode   => 0644,
+    mode   => '0644',
   }
 
   Cron {
     environment => concat(hiera('cron::environment', []), [
       $pythonpath,
     ]),
   }
 
   class {'nginx':
     geoip_country => $geoip ? {
@@ skipping 103 matching lines @@
   exec {"initialize_content":
     command => shellquote($initialize_content_exec),
     user => www,
     subscribe => [Exec["fetch_repo"], Exec["fetch_cms"]],
     refreshonly => true,
     environment => $pythonpath,
   }
 
   file {'/var/www':
     ensure => directory,
-    mode => 755,
+    mode => '755',

[mathias, 2017/06/20 17:58:55]

Now that we're at it, can't we make it uniform and always use the same notation,
be it with or without leading zero?

   }
 
   file {[
     "/var/cache/$repository",
     "/var/www/$vhost",
     "/var/www/docs",
   ]:
     ensure => directory,
     owner => www,
-    mode => 755,
+    mode => '755',
   }
 
   $update_cms_cmd = [
     'hg', 'pull',
     '--quiet',
     '--update',
     '--repository', '/opt/cms',
   ]
 
   cron {'update_cms':
@@ skipping 17 matching lines @@
   )
 
   cron {'update_repo':
     ensure => present,
     command => $update_webpage_cmd,
     user => www,
     minute  => '5-59/20',
   }
 
 }