Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: modules/web/manifests/server.pp

Issue 29469645: #1634 - Update file resource syntax in module web (Closed)
Left Patch Set: Created June 20, 2017, 5:16 p.m.
Right Patch Set: For comment number 2 Created June 21, 2017, 10:22 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 class web::server( 1 class web::server(
2 $vhost, 2 $vhost,
3 $repository, 3 $repository,
4 $certificate = hiera('web::server::certificate', 'undef'), 4 $certificate = hiera('web::server::certificate', 'undef'),
5 $private_key = hiera('web::server::private_key', 'undef'), 5 $private_key = hiera('web::server::private_key', 'undef'),
6 $is_default = false, 6 $is_default = false,
7 $aliases = undef, 7 $aliases = undef,
8 $custom_config = undef, 8 $custom_config = undef,
9 $multiplexer_locations = undef, 9 $multiplexer_locations = undef,
10 $geoip = false, 10 $geoip = false,
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 exec {"initialize_content": 139 exec {"initialize_content":
140 command => shellquote($initialize_content_exec), 140 command => shellquote($initialize_content_exec),
141 user => www, 141 user => www,
142 subscribe => [Exec["fetch_repo"], Exec["fetch_cms"]], 142 subscribe => [Exec["fetch_repo"], Exec["fetch_cms"]],
143 refreshonly => true, 143 refreshonly => true,
144 environment => $pythonpath, 144 environment => $pythonpath,
145 } 145 }
146 146
147 file {'/var/www': 147 file {'/var/www':
148 ensure => directory, 148 ensure => directory,
149 mode => '755', 149 mode => '0755',
mathias 2017/06/20 17:58:55 Now that we're at it, can't we make it uniform and
150 } 150 }
151 151
152 file {[ 152 file {[
153 "/var/cache/$repository", 153 "/var/cache/$repository",
154 "/var/www/$vhost", 154 "/var/www/$vhost",
155 "/var/www/docs", 155 "/var/www/docs",
156 ]: 156 ]:
157 ensure => directory, 157 ensure => directory,
158 owner => www, 158 owner => www,
159 mode => '755', 159 mode => '0755',
160 } 160 }
161 161
162 $update_cms_cmd = [ 162 $update_cms_cmd = [
163 'hg', 'pull', 163 'hg', 'pull',
164 '--quiet', 164 '--quiet',
165 '--update', 165 '--update',
166 '--repository', '/opt/cms', 166 '--repository', '/opt/cms',
167 ] 167 ]
168 168
169 cron {'update_cms': 169 cron {'update_cms':
(...skipping 17 matching lines...) Expand all
187 ) 187 )
188 188
189 cron {'update_repo': 189 cron {'update_repo':
190 ensure => present, 190 ensure => present,
191 command => $update_webpage_cmd, 191 command => $update_webpage_cmd,
192 user => www, 192 user => www,
193 minute => '5-59/20', 193 minute => '5-59/20',
194 } 194 }
195 195
196 } 196 }
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld