Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29471608: Issue 5043 - Update member page layout (Closed)

Created:
June 22, 2017, 6:08 p.m. by juliandoucette
Modified:
July 23, 2017, 1:53 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.acceptableads.com
Visibility:
Public.

Description

Issue 5043 - Update member page layout

Patch Set 1 #

Patch Set 2 : Removed accidental CSS change #

Total comments: 40

Patch Set 3 : Addressed comments #

Patch Set 4 : Changed 3em member back to 4em #

Patch Set 5 : Hard coded order of coalitions #

Total comments: 14

Patch Set 6 : Addressed comments #

Patch Set 7 : Fixed capitilization and 0px #

Total comments: 4

Patch Set 8 : Fixed regression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M pages/committee/members.tmpl View 1 2 3 4 5 6 7 4 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 14
juliandoucette
June 22, 2017, 6:08 p.m. (2017-06-22 18:08:42 UTC) #1
juliandoucette
On 2017/06/22 18:08:42, juliandoucette wrote: Ready for review. Note: I had to deviate from the ...
June 22, 2017, 6:15 p.m. (2017-06-22 18:15:00 UTC) #2
juliandoucette
@Ire do you want to have a look at this first so that we don't ...
June 22, 2017, 6:16 p.m. (2017-06-22 18:16:19 UTC) #3
ire
On 2017/06/22 18:16:19, juliandoucette wrote: > @Ire do you want to have a look at ...
June 23, 2017, 7:21 a.m. (2017-06-23 07:21:47 UTC) #4
juliandoucette
Added some reflections (sorry if I'm doing this in the middle of your review!) https://codereview.adblockplus.org/29471608/diff/29471621/pages/committee/members.tmpl ...
June 23, 2017, 12:55 p.m. (2017-06-23 12:55:22 UTC) #5
ire
You taught me about Jinja macros today :) 👍🏾 https://codereview.adblockplus.org/29471608/diff/29471621/pages/committee/members.tmpl File pages/committee/members.tmpl (right): https://codereview.adblockplus.org/29471608/diff/29471621/pages/committee/members.tmpl#newcode1 pages/committee/members.tmpl:1: ...
June 25, 2017, 7:31 p.m. (2017-06-25 19:31:11 UTC) #6
juliandoucette
Ready for review. https://codereview.adblockplus.org/29471608/diff/29471621/pages/committee/members.tmpl File pages/committee/members.tmpl (right): https://codereview.adblockplus.org/29471608/diff/29471621/pages/committee/members.tmpl#newcode34 pages/committee/members.tmpl:34: .member-list li On 2017/06/25 19:31:10, ire ...
June 26, 2017, 2:38 p.m. (2017-06-26 14:38:38 UTC) #7
ire
https://codereview.adblockplus.org/29471608/diff/29474638/pages/committee/members.tmpl File pages/committee/members.tmpl (right): https://codereview.adblockplus.org/29471608/diff/29474638/pages/committee/members.tmpl#newcode54 pages/committee/members.tmpl:54: padding-left: 0px; Unit not needed https://codereview.adblockplus.org/29471608/diff/29474638/pages/committee/members.tmpl#newcode84 pages/committee/members.tmpl:84: "title": "FOR-PROFIT ...
July 6, 2017, 3:41 p.m. (2017-07-06 15:41:22 UTC) #8
juliandoucette
@Jeen, @Tamara Please answer the following question [here](https://codereview.adblockplus.org/29471608/diff/29474638/pages/committee/members.tmpl#newcode335) Should we eventually translate the job titles ...
July 7, 2017, 2:20 p.m. (2017-07-07 14:20:00 UTC) #9
ire
Thanks :) https://codereview.adblockplus.org/29471608/diff/29474638/pages/committee/members.tmpl File pages/committee/members.tmpl (right): https://codereview.adblockplus.org/29471608/diff/29474638/pages/committee/members.tmpl#newcode54 pages/committee/members.tmpl:54: padding-left: 0px; On 2017/07/07 14:20:00, juliandoucette wrote: ...
July 10, 2017, 7:43 a.m. (2017-07-10 07:43:00 UTC) #10
juliandoucette
https://codereview.adblockplus.org/29471608/diff/29474638/pages/committee/members.tmpl File pages/committee/members.tmpl (right): https://codereview.adblockplus.org/29471608/diff/29474638/pages/committee/members.tmpl#newcode54 pages/committee/members.tmpl:54: padding-left: 0px; On 2017/07/10 07:43:00, ire wrote: > On ...
July 14, 2017, 12:10 p.m. (2017-07-14 12:10:45 UTC) #11
ire
It looks like some of the changes you made previously were undone. See comments below ...
July 17, 2017, 7:27 a.m. (2017-07-17 07:27:50 UTC) #12
juliandoucette
Thanks / Sorry :) https://codereview.adblockplus.org/29471608/diff/29489569/pages/committee/members.tmpl File pages/committee/members.tmpl (right): https://codereview.adblockplus.org/29471608/diff/29489569/pages/committee/members.tmpl#newcode404 pages/committee/members.tmpl:404: <h4>{{ group | translate("group-name-heading", "heading") ...
July 17, 2017, 10:37 a.m. (2017-07-17 10:37:40 UTC) #13
ire
July 17, 2017, 12:32 p.m. (2017-07-17 12:32:33 UTC) #14
On 2017/07/17 10:37:40, juliandoucette wrote:
> Thanks / Sorry :)

No worries. LGTM :)

Powered by Google App Engine
This is Rietveld