Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(304)

Issue 29473555: Issue 5345 - Whitelist $elemhide and $generichide domains where possible (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by Manish Jethani
Modified:
2 years, 5 months ago
Reviewers:
kzar
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/abp2blocklist
Visibility:
Public.

Description

For the following filter list: ##.sponsored-container-bottom @@||walmart.com^$elemhide Generate the following rule set: [ { "trigger": { "url-filter": "^https?://", "url-filter-is-case-sensitive": true, "unless-domain": [ "*walmart.com" ] }, "action": { "type": "css-display-none", "selector": ".sponsored-container-bottom" } } ]

Patch Set 1 #

Total comments: 20

Patch Set 2 : Address comments to Patch Set 1 #

Total comments: 3

Patch Set 3 : Generate unless-domain value outside while loop #

Total comments: 3

Patch Set 4 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -22 lines) Patch
M abp2blocklist.js View 1 1 chunk +14 lines, -1 line 0 comments Download
M lib/abp2blocklist.js View 1 2 3 4 chunks +48 lines, -12 lines 1 comment Download
M test/abp2blocklist.js View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 13
Manish Jethani
2 years, 5 months ago (2017-06-24 14:48:59 UTC) #1
Manish Jethani
This changes the implementation of $elemhide and $generichide so that we whitelist the domain where ...
2 years, 5 months ago (2017-06-24 14:54:15 UTC) #2
kzar
https://codereview.adblockplus.org/29473555/diff/29473556/abp2blocklist.js File abp2blocklist.js (right): https://codereview.adblockplus.org/29473555/diff/29473556/abp2blocklist.js#newcode37 abp2blocklist.js:37: // If the rule set is too huge, Node.js ...
2 years, 5 months ago (2017-07-07 11:40:13 UTC) #3
kzar
(Moving Sebastian to Cc on this one.)
2 years, 5 months ago (2017-07-07 11:42:51 UTC) #4
Manish Jethani
Patch Set 2: Address comments to Patch Set 1 Some comments inline. https://codereview.adblockplus.org/29473555/diff/29473556/abp2blocklist.js File abp2blocklist.js ...
2 years, 5 months ago (2017-07-08 05:33:59 UTC) #5
kzar
https://codereview.adblockplus.org/29473555/diff/29473556/abp2blocklist.js File abp2blocklist.js (right): https://codereview.adblockplus.org/29473555/diff/29473556/abp2blocklist.js#newcode37 abp2blocklist.js:37: // If the rule set is too huge, Node.js ...
2 years, 5 months ago (2017-07-10 12:33:08 UTC) #6
Manish Jethani
Patch Set 3: Generate unless-domain value outside while loop https://codereview.adblockplus.org/29473555/diff/29473556/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29473555/diff/29473556/lib/abp2blocklist.js#newcode435 lib/abp2blocklist.js:435: ...
2 years, 5 months ago (2017-07-11 11:19:18 UTC) #7
kzar
https://codereview.adblockplus.org/29473555/diff/29483555/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29473555/diff/29483555/lib/abp2blocklist.js#newcode556 lib/abp2blocklist.js:556: genericSelectorExceptionDomains.add(name); On 2017/07/11 11:19:18, Manish Jethani wrote: > On ...
2 years, 5 months ago (2017-07-11 12:20:03 UTC) #8
Manish Jethani
https://codereview.adblockplus.org/29473555/diff/29486562/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29473555/diff/29486562/lib/abp2blocklist.js#newcode417 lib/abp2blocklist.js:417: let unlessDomain = exceptionDomains.size > 0 ? [] : ...
2 years, 5 months ago (2017-07-11 16:28:39 UTC) #9
kzar
LGTM, go ahead and push when you're ready to. https://codereview.adblockplus.org/29473555/diff/29486562/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29473555/diff/29486562/lib/abp2blocklist.js#newcode417 lib/abp2blocklist.js:417: ...
2 years, 5 months ago (2017-07-11 16:30:37 UTC) #10
Manish Jethani
Patch Set 4: Rebase Rebased on the current master.
2 years, 5 months ago (2017-07-11 17:33:04 UTC) #11
Manish Jethani
https://codereview.adblockplus.org/29473555/diff/29486569/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29473555/diff/29486569/lib/abp2blocklist.js#newcode157 lib/abp2blocklist.js:157: characters.slice(hostnameStart, endingChar ? i : i + 1).join("") This ...
2 years, 5 months ago (2017-07-12 08:59:56 UTC) #12
kzar
2 years, 5 months ago (2017-07-12 09:22:13 UTC) #13
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5