Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1187)

Issue 29474565: Issue 5350 - Setup Help Center Boilerplate (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by ire
Modified:
2 years ago
Reviewers:
juliandoucette
Visibility:
Public.

Description

Issue 5350 - Setup Help Center Boilerplate

Patch Set 1 #

Total comments: 38

Patch Set 2 : Add website defaults #

Total comments: 19

Patch Set 3 : Move browserlist to package.json, Fix font urls, Add blocks in template #

Patch Set 4 : Update colour variable names and Font stack #

Patch Set 5 : Diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1638 lines, -0 lines) Patch
A .gitignore View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A .hgignore View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A README.md View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
A gulpfile.js View 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download
A package.json View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A pages/index.md View 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A settings.ini View 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A static/fonts/Source-Sans-Pro-300/LICENSE.txt View 2 3 4 1 chunk +93 lines, -0 lines 0 comments Download
A static/fonts/Source-Sans-Pro-300/Source-Sans-Pro-300.eot View 2 3 4 Binary file 0 comments Download
A static/fonts/Source-Sans-Pro-300/Source-Sans-Pro-300.svg View 2 3 4 1 chunk +347 lines, -0 lines 0 comments Download
A static/fonts/Source-Sans-Pro-300/Source-Sans-Pro-300.ttf View 2 3 4 Binary file 0 comments Download
A static/fonts/Source-Sans-Pro-300/Source-Sans-Pro-300.woff View 2 3 4 Binary file 0 comments Download
A static/fonts/Source-Sans-Pro-300/Source-Sans-Pro-300.woff2 View 2 3 4 Binary file 0 comments Download
A static/fonts/Source-Sans-Pro-400/LICENSE.txt View 2 3 4 1 chunk +93 lines, -0 lines 0 comments Download
A static/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.eot View 2 3 4 Binary file 0 comments Download
A static/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.svg View 2 3 4 1 chunk +345 lines, -0 lines 0 comments Download
A static/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.ttf View 2 3 4 Binary file 0 comments Download
A static/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.woff View 2 3 4 Binary file 0 comments Download
A static/fonts/Source-Sans-Pro-400/Source-Sans-Pro-400.woff2 View 2 3 4 Binary file 0 comments Download
A static/fonts/Source-Sans-Pro-700/LICENSE.txt View 2 3 4 1 chunk +93 lines, -0 lines 0 comments Download
A static/fonts/Source-Sans-Pro-700/Source-Sans-Pro-700.eot View 2 3 4 Binary file 0 comments Download
A static/fonts/Source-Sans-Pro-700/Source-Sans-Pro-700.svg View 2 3 4 1 chunk +337 lines, -0 lines 0 comments Download
A static/fonts/Source-Sans-Pro-700/Source-Sans-Pro-700.ttf View 2 3 4 Binary file 0 comments Download
A static/fonts/Source-Sans-Pro-700/Source-Sans-Pro-700.woff View 2 3 4 Binary file 0 comments Download
A static/fonts/Source-Sans-Pro-700/Source-Sans-Pro-700.woff2 View 2 3 4 Binary file 0 comments Download
A static/js/vendor/html5shiv.min.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
A static/js/vendor/ie8.min.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
A static/js/vendor/respond.min.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
A static/scss/base/_font.scss View 1 2 3 4 1 chunk +63 lines, -0 lines 0 comments Download
A static/scss/base/_reset.scss View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
A static/scss/base/_variables.scss View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
A static/scss/main.scss View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A templates/default.tmpl View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 15
ire
2 years ago (2017-06-26 10:52:36 UTC) #1
juliandoucette
Thanks Ire, Here are a few of my first impressions. https://codereview.adblockplus.org/29474565/diff/29474566/.browserslistrc File .browserslistrc (right): https://codereview.adblockplus.org/29474565/diff/29474566/.browserslistrc#newcode1 ...
2 years ago (2017-06-26 12:37:35 UTC) #2
ire
https://codereview.adblockplus.org/29474565/diff/29474566/.browserslistrc File .browserslistrc (right): https://codereview.adblockplus.org/29474565/diff/29474566/.browserslistrc#newcode1 .browserslistrc:1: # This file is part of help.eyeo.com. On 2017/06/26 ...
2 years ago (2017-06-27 14:18:39 UTC) #3
juliandoucette
Done. https://codereview.adblockplus.org/29474565/diff/29474566/.browserslistrc File .browserslistrc (right): https://codereview.adblockplus.org/29474565/diff/29474566/.browserslistrc#newcode1 .browserslistrc:1: # This file is part of help.eyeo.com. On ...
2 years ago (2017-07-03 15:37:56 UTC) #4
ire
Thanks, made some updates. https://codereview.adblockplus.org/29474565/diff/29474566/.browserslistrc File .browserslistrc (right): https://codereview.adblockplus.org/29474565/diff/29474566/.browserslistrc#newcode1 .browserslistrc:1: # This file is part ...
2 years ago (2017-07-04 09:33:18 UTC) #5
juliandoucette
Thanks Ire :) -- Followup below. https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss File static/scss/base/_variables.scss (right): https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss#newcode22 static/scss/base/_variables.scss:22: $pale-white: #ECECEC; On ...
2 years ago (2017-07-04 10:34:41 UTC) #6
ire
https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss File static/scss/base/_variables.scss (right): https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss#newcode22 static/scss/base/_variables.scss:22: $pale-white: #ECECEC; On 2017/07/04 10:34:40, juliandoucette wrote: > On ...
2 years ago (2017-07-04 11:19:04 UTC) #7
juliandoucette
https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss File static/scss/base/_variables.scss (right): https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss#newcode39 static/scss/base/_variables.scss:39: $font-family: "Source Sans Pro", -apple-system, BlinkMacSystemFont, On 2017/07/04 11:19:03, ...
2 years ago (2017-07-04 12:24:52 UTC) #8
ire
https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss File static/scss/base/_variables.scss (right): https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss#newcode39 static/scss/base/_variables.scss:39: $font-family: "Source Sans Pro", -apple-system, BlinkMacSystemFont, On 2017/07/04 12:24:51, ...
2 years ago (2017-07-04 13:36:43 UTC) #9
juliandoucette
https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss File static/scss/base/_variables.scss (right): https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss#newcode39 static/scss/base/_variables.scss:39: $font-family: "Source Sans Pro", -apple-system, BlinkMacSystemFont, On 2017/07/04 13:36:43, ...
2 years ago (2017-07-04 14:51:16 UTC) #10
ire
https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss File static/scss/base/_variables.scss (right): https://codereview.adblockplus.org/29474565/diff/29474566/static/scss/base/_variables.scss#newcode22 static/scss/base/_variables.scss:22: $pale-white: #ECECEC; On 2017/07/04 11:19:03, ire wrote: > On ...
2 years ago (2017-07-05 10:14:11 UTC) #11
juliandoucette
Are you still planning to remove meta data and polyfills from this patchset? Also, it ...
2 years ago (2017-07-05 14:26:30 UTC) #12
ire
On 2017/07/05 14:26:30, juliandoucette wrote: > Are you still planning to remove meta data and ...
2 years ago (2017-07-05 21:32:50 UTC) #13
ire
On 2017/07/05 21:32:50, ire wrote: > Okay I'll push an update. Done.
2 years ago (2017-07-06 07:36:27 UTC) #14
juliandoucette
2 years ago (2017-07-06 13:13:35 UTC) #15
LGTM

https://codereview.adblockplus.org/29474565/diff/29474566/templates/default.tmpl
File templates/default.tmpl (right):

https://codereview.adblockplus.org/29474565/diff/29474566/templates/default.t...
templates/default.tmpl:23: <title>{{ title | translate("page-title", "Meta page
title") }}</title>
On 2017/07/04 09:33:15, ire wrote:
> On 2017/07/03 15:37:54, juliandoucette wrote:
> > > Done. I thought most/all meta tags were handled by the other issue.
> > 
> > They are, actually. I didn't know that you were considering them. You can
> safely
> > exclude tags from website-defaults meta [standard.tmpl, social.tmpl, etc] if
> you
> > plan on including them from website-defaults (which you probably should)
> > 
> >
>
https://codereview.adblockplus.org/29469558/diff/29470671/includes/meta/stand...
> 
> Yes that was the plan. If it's okay by you, I'll leave the metadata I
currently
> have there for now. Then when the metadata from website defaults are ready,
I'll
> swap for the ones from there. 

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5