.browserslistrc - Issue 29474565: Issue 5350 - Setup Help Center Boilerplate

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .browserslistrc

Issue 29474565: Issue 5350 - Setup Help Center Boilerplate (Closed)

Patch Set: Created June 26, 2017, 10:52 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # This file is part of help.eyeo.com.
	juliandoucette 2017/06/26 12:37:33 Is there anything in this file that should be uniq Is there anything in this file that should be unique to this project and not others too? If not, then I would suggest implementing this in codingtools (repo). ire 2017/06/27 14:18:37 Yes this should be company-wide. However, I coul Show quoted text On 2017/06/26 12:37:33, juliandoucette wrote: > Is there anything in this file that should be unique to this project and not > others too? If not, then I would suggest implementing this in codingtools > (repo). Yes this should be company-wide. However, I couldn't find a way to use an externally-located .browserlistrc file with autoprefixer in this case. Also, perhaps this should be in website-defaults instead? I think browserlist is more a frontend website thing. juliandoucette 2017/07/03 15:37:54 Acknowledged. Perhaps it's better to put this in Show quoted text On 2017/06/27 14:18:37, ire wrote: > On 2017/06/26 12:37:33, juliandoucette wrote: > > Is there anything in this file that should be unique to this project and not > > others too? If not, then I would suggest implementing this in codingtools > > (repo). > > Yes this should be company-wide. > > However, I couldn't find a way to use an externally-located .browserlistrc file > with autoprefixer in this case. Also, perhaps this should be in website-defaults > instead? I think browserlist is more a frontend website thing. Acknowledged. Perhaps it's better to put this in package.json then? ire 2017/07/04 09:33:14 Done. Show quoted text On 2017/07/03 15:37:54, juliandoucette wrote: > On 2017/06/27 14:18:37, ire wrote: > > On 2017/06/26 12:37:33, juliandoucette wrote: > > > Is there anything in this file that should be unique to this project and not > > > others too? If not, then I would suggest implementing this in codingtools > > > (repo). > > > > Yes this should be company-wide. > > > > However, I couldn't find a way to use an externally-located .browserlistrc > file > > with autoprefixer in this case. Also, perhaps this should be in > website-defaults > > instead? I think browserlist is more a frontend website thing. > > Acknowledged. > > Perhaps it's better to put this in package.json then? Done.
	2 # Copyright (C) 2017 Eyeo GmbH

	3 #

	4 # help.eyeo.com is free software: you can redistribute it and/or modify

	5 # it under the terms of the GNU General Public License as published by

	6 # the Free Software Foundation, either version 3 of the License, or

	7 # (at your option) any later version.

	8 #

	9 # help.eyeo.com is distributed in the hope that it will be useful,

	10 # but WITHOUT ANY WARRANTY; without even the implied warranty of

	11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	12 # GNU General Public License for more details.

	13 #

	14 # You should have received a copy of the GNU General Public License

	15 # along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>.

	16

	17 last 2 versions

	18 ie >= 9

OLD	NEW

« no previous file with comments | « no previous file | .gitignore » ('j') | .hgignore » ('J')