templates/default.tmpl - Issue 29474565: Issue 5350 - Setup Help Center Boilerplate

Side by Side Diff: templates/default.tmpl

Issue 29474565: Issue 5350 - Setup Help Center Boilerplate (Closed)

Patch Set: Add website defaults Created June 27, 2017, 2:17 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {#	1 <!DOCTYPE html>

2 # This file is part of help.eyeo.com.	2 <!--

3 # Copyright (C) 2017 Eyeo GmbH	3 This file is part of help.eyeo.com.

4 #	4 Copyright (C) 2017 Eyeo GmbH

5 # help.eyeo.com is free software: you can redistribute it and/or modify	5

6 # it under the terms of the GNU General Public License as published by	6 help.eyeo.com is free software: you can redistribute it and/or modify

7 # the Free Software Foundation, either version 3 of the License, or	7 it under the terms of the GNU General Public License as published by

8 # (at your option) any later version.	8 the Free Software Foundation, either version 3 of the License, or

9 #	9 (at your option) any later version.

10 # help.eyeo.com is distributed in the hope that it will be useful,	10

11 # but WITHOUT ANY WARRANTY; without even the implied warranty of	11 help.eyeo.com is distributed in the hope that it will be useful,

12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	12 but WITHOUT ANY WARRANTY; without even the implied warranty of

13 # GNU General Public License for more details.	13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

14 #	14 GNU General Public License for more details.

15 # You should have received a copy of the GNU General Public License	15

16 # along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>.	16 You should have received a copy of the GNU General Public License

17 #}<!DOCTYPE html>	17 along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>.

	18 -->

18 <html	19 <html

19 lang="{{ locale }}"	20 lang="{{ locale }}"
	juliandoucette 2017/07/03 15:37:55 Note: I'm probably going to include these html-att Note: I'm probably going to include these html-attributes in website-defaults e.g. <html <?include meta/html-attributes ?>> I don't know if I'm taking it a little too far now :D - let me know what you think. My thinking is every website seems to have these attributes... why not default them?. ire 2017/07/04 09:33:17 Haha no I don't think you're going too far. In thi Show quoted text On 2017/07/03 15:37:55, juliandoucette wrote: > Note: I'm probably going to include these html-attributes in website-defaults > e.g. > > <html <?include meta/html-attributes ?>> > > I don't know if I'm taking it a little too far now :D - let me know what you > think. > > My thinking is every website seems to have these attributes... why not default > them?. Haha no I don't think you're going too far. In think we should default as much as possible, takes the uncertainty out of things that shouldn't be uncertain.
20 dir="{{ "rtl" if config.has_option("rtl", locale) else "ltr" }}">	21 dir="{{ "rtl" if config.has_option("rtl", locale) else "ltr" }}">

21 <head>	22 <head>

22 <meta charset="utf-8">	23 <meta charset="utf-8">
	juliandoucette 2017/07/03 15:37:55 Like I mentioned in the last patchset, these are i Like I mentioned in the last patchset, these are in website-defaults meta/standard.tmpl. Sorry about the confusion. ire 2017/07/04 09:33:17 No problem. See my comment about swapping these ou Show quoted text On 2017/07/03 15:37:55, juliandoucette wrote: > Like I mentioned in the last patchset, these are in website-defaults > meta/standard.tmpl. Sorry about the confusion. No problem. See my comment about swapping these out when website-defaults meta are ready.
	24 <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to- fit=no">

	25 <meta http-equiv="x-ua-compatible" content="ie=edge">

	26

23 <title>{{ title \| translate("page-title", "Meta page title") }}</title>	27 <title>{{ title \| translate("page-title", "Meta page title") }}</title>

24 <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to- fit=no">

25	28

26 <link rel="stylesheet" href="/css/main.css">	29 <!--[if IE 8]>
	juliandoucette 2017/07/03 15:37:56 Like I mentioned in the vendor css, I think should Like I mentioned in the vendor css, I think should find a way to include these from website-defaults (you could exclude them for now and add them later if we don't find a way in time). ire 2017/07/04 09:33:17 Acknowledged. Show quoted text On 2017/07/03 15:37:56, juliandoucette wrote: > Like I mentioned in the vendor css, I think should find a way to include these > from website-defaults (you could exclude them for now and add them later if we > don't find a way in time). Acknowledged.
	30 <script src="js/vendor/ie8.js"></script>

	31 <![endif]-->

	32

	33 <link rel="stylesheet" href="css/main.css">

	34

	35 <!--[if lt IE 9]>
	juliandoucette 2017/07/03 15:37:55 See comment above (ie8.js). See comment above (ie8.js). ire 2017/07/04 09:33:17 Acknowledged. Show quoted text On 2017/07/03 15:37:55, juliandoucette wrote: > See comment above (ie8.js). Acknowledged.
	36 <script src="js/vendor/html5shiv.js"></script>

	37 <script src="js/vendor/respond.min.js"></script>

	38 <![endif]-->

27	39

28 {{ head \| safe }}	40 {{ head \| safe }}
	juliandoucette 2017/07/03 15:37:55 I don't think {{ head \| safe }} does anything with I don't think {{ head \| safe }} does anything without a {% block head %}. ire 2017/07/04 09:33:17 Done. That's me not understanding how the cms work Show quoted text On 2017/07/03 15:37:55, juliandoucette wrote: > I don't think {{ head \| safe }} does anything without a {% block head %}. Done. That's me not understanding how the cms works :P
29 </head>	41 </head>

30 <body>	42 <body>

31 {{ body \| safe }}	43 {{ body \| safe }}
	juliandoucette 2017/07/03 15:37:55 I don't think you can extend the body in a child t I don't think you can extend the body in a child template without a {% block body %}. ire 2017/07/04 09:33:17 Done. Show quoted text On 2017/07/03 15:37:55, juliandoucette wrote: > I don't think you can extend the body in a child template without a {% block > body %}. Done.
32 </body>	44 </body>

33 <html>	45 <html>

OLD	NEW

« static/scss/base/_font.scss ('K') | « static/scss/main.scss ('k') | no next file » | no next file with comments »