Delta Between Two Patch Sets: templates/default.tmpl
Issue 29474565:
Issue 5350 - Setup Help Center Boilerplate (Closed)
Left Patch Set:
Created June 26, 2017, 10:52 a.m.
Right Patch Set: Diff
Created July 6, 2017, 7:34 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« static/scss/main.scss ('k')
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 {# | 1 <!DOCTYPE html> |
|
juliandoucette
2017/06/26 12:37:34
We may want to include a license header in the HTM
ire
2017/06/27 14:18:38
Done.
| |
| 2 # This file is part of help.eyeo.com. | 2 <!-- |
| 3 # Copyright (C) 2017 Eyeo GmbH | 3 This file is part of help.eyeo.com. |
| 4 # | 4 Copyright (C) 2017 Eyeo GmbH |
| 5 # help.eyeo.com is free software: you can redistribute it and/or modify | 5 |
| 6 # it under the terms of the GNU General Public License as published by | 6 help.eyeo.com is free software: you can redistribute it and/or modify |
| 7 # the Free Software Foundation, either version 3 of the License, or | 7 it under the terms of the GNU General Public License as published by |
| 8 # (at your option) any later version. | 8 the Free Software Foundation, either version 3 of the License, or |
| 9 # | 9 (at your option) any later version. |
| 10 # help.eyeo.com is distributed in the hope that it will be useful, | 10 |
| 11 # but WITHOUT ANY WARRANTY; without even the implied warranty of | 11 help.eyeo.com is distributed in the hope that it will be useful, |
| 12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 12 but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 13 # GNU General Public License for more details. | 13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| 14 # | 14 GNU General Public License for more details. |
| 15 # You should have received a copy of the GNU General Public License | 15 |
| 16 # along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>. | 16 You should have received a copy of the GNU General Public License |
| 17 #}<!DOCTYPE html> | 17 along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>. |
| 18 --> | |
| 18 <html | 19 <html |
| 19 lang="{{ locale }}" | 20 lang="{{ locale }}" |
| 20 dir="{{ "rtl" if config.has_option("rtl", locale) else "ltr" }}"> | 21 dir="{{ "rtl" if config.has_option("rtl", locale) else "ltr" }}"> |
| 21 <head> | 22 <head> |
| 22 <meta charset="utf-8"> | 23 <meta charset="utf-8"> |
| 24 <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to- fit=no"> | |
| 25 <meta http-equiv="x-ua-compatible" content="ie=edge"> | |
| 26 | |
| 23 <title>{{ title | translate("page-title", "Meta page title") }}</title> | 27 <title>{{ title | translate("page-title", "Meta page title") }}</title> |
|
juliandoucette
2017/06/26 12:37:34
NIT: I would suggest putting the IE header (missin
ire
2017/06/27 14:18:38
Done. I thought most/all meta tags were handled by
juliandoucette
2017/07/03 15:37:54
They are, actually. I didn't know that you were co
ire
2017/07/04 09:33:15
Yes that was the plan. If it's okay by you, I'll l
juliandoucette
2017/07/06 13:13:34
Acknowledged.
| |
| 24 <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to- fit=no"> | |
| 25 | 28 |
| 26 <link rel="stylesheet" href="/css/main.css"> | 29 <!--[if IE 8]> |
|
juliandoucette
2017/06/26 12:37:34
I think the CMS will correct the path if you exclu
ire
2017/06/27 14:18:38
Done.
| |
| 30 <script src="js/vendor/ie8.js"></script> | |
| 31 <![endif]--> | |
| 27 | 32 |
| 28 {{ head | safe }} | 33 <link rel="stylesheet" href="css/main.css"> |
| 34 | |
| 35 <!--[if lt IE 9]> | |
| 36 <script src="js/vendor/html5shiv.js"></script> | |
| 37 <script src="js/vendor/respond.min.js"></script> | |
| 38 <![endif]--> | |
| 39 | |
| 40 {% block head %} | |
| 41 {{ head | safe }} | |
| 42 {% endblock %} | |
| 29 </head> | 43 </head> |
| 30 <body> | 44 <body> |
| 31 {{ body | safe }} | 45 {% block body %} |
| 46 {{ body | safe }} | |
| 47 {% endblock %} | |
| 32 </body> | 48 </body> |
| 33 <html> | 49 <html> |
| LEFT | RIGHT |
« static/scss/main.scss ('k')
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
