templates/default.tmpl - Issue 29474565: Issue 5350 - Setup Help Center Boilerplate

Delta Between Two Patch Sets: templates/default.tmpl

Issue 29474565: Issue 5350 - Setup Help Center Boilerplate (Closed)

Left Patch Set: Add website defaults Created June 27, 2017, 2:17 p.m.

Right Patch Set: Diff Created July 6, 2017, 7:34 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 This file is part of help.eyeo.com.	3 This file is part of help.eyeo.com.

4 Copyright (C) 2017 Eyeo GmbH	4 Copyright (C) 2017 Eyeo GmbH

5	5

6 help.eyeo.com is free software: you can redistribute it and/or modify	6 help.eyeo.com is free software: you can redistribute it and/or modify

7 it under the terms of the GNU General Public License as published by	7 it under the terms of the GNU General Public License as published by

8 the Free Software Foundation, either version 3 of the License, or	8 the Free Software Foundation, either version 3 of the License, or

9 (at your option) any later version.	9 (at your option) any later version.

10	10

11 help.eyeo.com is distributed in the hope that it will be useful,	11 help.eyeo.com is distributed in the hope that it will be useful,

12 but WITHOUT ANY WARRANTY; without even the implied warranty of	12 but WITHOUT ANY WARRANTY; without even the implied warranty of

13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

14 GNU General Public License for more details.	14 GNU General Public License for more details.

15	15

16 You should have received a copy of the GNU General Public License	16 You should have received a copy of the GNU General Public License

17 along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>.	17 along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>.

18 -->	18 -->

19 <html	19 <html

20 lang="{{ locale }}"	20 lang="{{ locale }}"
juliandoucette 2017/07/03 15:37:55 Note: I'm probably going to include these html-att Note: I'm probably going to include these html-attributes in website-defaults e.g. <html <?include meta/html-attributes ?>> I don't know if I'm taking it a little too far now :D - let me know what you think. My thinking is every website seems to have these attributes... why not default them?. ire 2017/07/04 09:33:17 Haha no I don't think you're going too far. In thi Show quoted text On 2017/07/03 15:37:55, juliandoucette wrote: > Note: I'm probably going to include these html-attributes in website-defaults > e.g. > > <html <?include meta/html-attributes ?>> > > I don't know if I'm taking it a little too far now :D - let me know what you > think. > > My thinking is every website seems to have these attributes... why not default > them?. Haha no I don't think you're going too far. In think we should default as much as possible, takes the uncertainty out of things that shouldn't be uncertain.
21 dir="{{ "rtl" if config.has_option("rtl", locale) else "ltr" }}">	21 dir="{{ "rtl" if config.has_option("rtl", locale) else "ltr" }}">

22 <head>	22 <head>

23 <meta charset="utf-8">	23 <meta charset="utf-8">
juliandoucette 2017/07/03 15:37:55 Like I mentioned in the last patchset, these are i Like I mentioned in the last patchset, these are in website-defaults meta/standard.tmpl. Sorry about the confusion. ire 2017/07/04 09:33:17 No problem. See my comment about swapping these ou Show quoted text On 2017/07/03 15:37:55, juliandoucette wrote: > Like I mentioned in the last patchset, these are in website-defaults > meta/standard.tmpl. Sorry about the confusion. No problem. See my comment about swapping these out when website-defaults meta are ready.
24 <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to- fit=no">	24 <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to- fit=no">

25 <meta http-equiv="x-ua-compatible" content="ie=edge">	25 <meta http-equiv="x-ua-compatible" content="ie=edge">

26	26

27 <title>{{ title \| translate("page-title", "Meta page title") }}</title>	27 <title>{{ title \| translate("page-title", "Meta page title") }}</title>

28	28

29 <!--[if IE 8]>	29 <!--[if IE 8]>
juliandoucette 2017/07/03 15:37:56 Like I mentioned in the vendor css, I think should Like I mentioned in the vendor css, I think should find a way to include these from website-defaults (you could exclude them for now and add them later if we don't find a way in time). ire 2017/07/04 09:33:17 Acknowledged. Show quoted text On 2017/07/03 15:37:56, juliandoucette wrote: > Like I mentioned in the vendor css, I think should find a way to include these > from website-defaults (you could exclude them for now and add them later if we > don't find a way in time). Acknowledged.
30 <script src="js/vendor/ie8.js"></script>	30 <script src="js/vendor/ie8.js"></script>

31 <![endif]-->	31 <![endif]-->

32	32

33 <link rel="stylesheet" href="css/main.css">	33 <link rel="stylesheet" href="css/main.css">

34	34

35 <!--[if lt IE 9]>	35 <!--[if lt IE 9]>
juliandoucette 2017/07/03 15:37:55 See comment above (ie8.js). See comment above (ie8.js). ire 2017/07/04 09:33:17 Acknowledged. Show quoted text On 2017/07/03 15:37:55, juliandoucette wrote: > See comment above (ie8.js). Acknowledged.
36 <script src="js/vendor/html5shiv.js"></script>	36 <script src="js/vendor/html5shiv.js"></script>

37 <script src="js/vendor/respond.min.js"></script>	37 <script src="js/vendor/respond.min.js"></script>

38 <![endif]-->	38 <![endif]-->

39	39

40 {{ head \| safe }}	40 {% block head %}
juliandoucette 2017/07/03 15:37:55 I don't think {{ head \| safe }} does anything with I don't think {{ head \| safe }} does anything without a {% block head %}. ire 2017/07/04 09:33:17 Done. That's me not understanding how the cms work Show quoted text On 2017/07/03 15:37:55, juliandoucette wrote: > I don't think {{ head \| safe }} does anything without a {% block head %}. Done. That's me not understanding how the cms works :P
	41 {{ head \| safe }}

	42 {% endblock %}

41 </head>	43 </head>

42 <body>	44 <body>

43 {{ body \| safe }}	45 {% block body %}
juliandoucette 2017/07/03 15:37:55 I don't think you can extend the body in a child t I don't think you can extend the body in a child template without a {% block body %}. ire 2017/07/04 09:33:17 Done. Show quoted text On 2017/07/03 15:37:55, juliandoucette wrote: > I don't think you can extend the body in a child template without a {% block > body %}. Done.
	46 {{ body \| safe }}

	47 {% endblock %}

44 </body>	48 </body>

45 <html>	49 <html>

LEFT	RIGHT