Remove trailing slashes from file URLs in web::server class

modules/web/templates/site.conf.erb

Index: modules/web/templates/site.conf.erb
diff --git a/modules/web/templates/site.conf.erb b/modules/web/templates/site.conf.erb
index 538ff66bb2d606b55393d2fc92d2f82e158e6959..b29701076adfef31e8ee1b67fb53b71d615ae689 100644
--- a/modules/web/templates/site.conf.erb
+++ b/modules/web/templates/site.conf.erb
@@ -46,6 +46,13 @@ location /
   rewrite ^/$ /$index_page last;
   rewrite ^/(\w\w(_\w\w)?)$ /$1/ permanent;
   rewrite ^/(\w\w(_\w\w)?)/$ /$1/$index_page last;
+
+  # Remove accidental trailing slash
+
+  if (!-d "$document_root/$uri")

[Wladimir Palant, 2017/06/26 22:20:47]

You probably want to do this only for actual files, not just for any input that
might be a directory.

[mathias, 2017/06/27 10:04:01]

In fact i wanted to explicitly express that this is done "for anything but
directories", in contrast to Nginx behavior for serving directories. But you're
right: The current version would also match absent resources, which in turn
could lead to some overhead with invalid requests and issues with i.e. FCGI
backends.

+  {
+    rewrite ^(/.*)/$ $1 redirect;

[Wladimir Palant, 2017/06/26 22:20:47]

In the case we are talking about (something that was previously a directory
became a regular page) this will cause a redirect loop because the URL without
the slash has a permanent redirect stored in local cache. An internal redirect
would do but is ugly IMHO, maybe redirect with a "?no_redirect" added to the
URL? The pages specify a canonical URL, so we shouldn't have this URL mess up
search results.

[mathias, 2017/06/27 10:04:01]

Acknowledged.

+  }
 }
 
 <% if @multiplexer_locations %>