Issue 5326 - General tab (HTML, strings and functionality)

skin/new-options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2017 eyeo GmbH
+ * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 80 matching lines @@
 input[type="text"],
 input[type="search"],
 textarea
 {
   -webkit-box-sizing: border-box;
   -moz-box-sizing: border-box;
   box-sizing: border-box;
 }
 
 button[role="checkbox"],
 #dialog-body .table button[role="checkbox"]

[Thomas Greiner, 2017/08/09 18:14:50]

Detail: Why are those duplicated selectors for checkboxes necessary? On first
glance it appears to work without it.

[saroyanm, 2017/08/14 14:00:11]

I'll recheck, but I almost sure I did it because of specificity

[Thomas Greiner, 2017/08/15 17:10:30]

Acknowledged.

[saroyanm, 2017/08/16 14:17:39]

Yes it is because of specificity, anyway I'll revisit the Dialog styles
separately.

[Thomas Greiner, 2017/08/16 17:57:08]

Acknowledged.

 {
   width: 18px;
   height: 18px;
   margin-top: 0px;
   -moz-margin-end: 20px;
   -webkit-margin-end: 20px;
   padding: 0px;
   border: none;
   background-color: transparent;
   background-position: -51px 0px;
@@ skipping 255 matching lines @@
 {
   padding-top: 0px;
   padding-bottom: 6px;
 }
 
   .table li.empty-placeholder
 {
   background-color: #F5F5F5;
 }
 
-.table li [data-single='visible'],
-.table li:first-child:nth-last-child(2) [data-single='hidden']

[Thomas Greiner, 2017/08/09 18:14:51]

Detail: It's a nice trick to select an element if it's the only one but it's not
easy to understand because you'd have to know that the last element will always
be the `<template>` element.

Therefore let's use `li:first-of-type:last-of-type` instead because it makes
clear that we're only selecting the element if it's both the first and last
`<li>`.

[saroyanm, 2017/08/14 14:00:10]

I'll try that.

[saroyanm, 2017/08/16 14:17:38]

Done.

+.table li [data-single="visible"],
+.table li:first-of-type:last-of-type [data-single="hidden"]
 {
   display: none;
 }
 
-.table li:first-child:nth-last-child(2) [data-single='visible']

[Thomas Greiner, 2017/08/09 18:14:50]

Suggestion: You could move that selector into the rule above using
`li:not(:first-of-type:last-of-type)` to avoid having to know whether it's
supposed to be a block or an inline element.

[saroyanm, 2017/08/14 14:00:11]

Acknowledged.

[saroyanm, 2017/08/16 14:17:38]

Apparently it's not possible to have two pseudo classes in the :not

[Thomas Greiner, 2017/08/16 17:57:08]

Interesting, I wasn't aware of that. They only accept simple selectors according
to https://www.w3.org/TR/css3-selectors/#negation so you're right.

FYI: The upcoming Selectors Level 4 standard appears to change that so it
accepts a selector list instead. See https://www.w3.org/TR/selectors4/#negation

+.table li:first-of-type:last-of-type [data-single="visible"]
 {
   display: block;
 }
 
 .table label
 {
   vertical-align: top;
 }
 
 .table.cols
@@ skipping 193 matching lines @@
   Advanced tab content
 */
 
 #all-filter-lists-table li.show-message .last-update,
 #all-filter-lists-table li:not(.show-message) .message,
 #custom-filters:not([data-mode="empty"]) #empty-custom-filters,
 #custom-filters[data-mode="empty"] #custom-filters-raw,
 #custom-filters:not([data-mode="write"]) #custom-filters-raw-controls,
 #custom-filters:not([data-mode="read"]) #custom-filters-edit,
 .state span,
-#acceptable-ads:not(.show-dnt-notification) #no-dnt
+#acceptable-ads:not(.show-dnt-notification) #dnt
 {
   display: none;
 }
 
 #all-filter-lists-table
 {
   display: inline-block;
 }
 
 #all-filter-lists-table
@@ skipping 450 matching lines @@
 #dialog .url
 {
   margin-top: 10px;
   margin-bottom: 20px;
   word-wrap: break-word;
 }
 
 body:not([data-dialog="custom"]) #dialog-title-custom,
 body:not([data-dialog="custom"]) #dialog-content-custom,
 body:not([data-dialog="language-add"]) #dialog-title-language-add,
-body:not([data-dialog="language-add"]) #dialog-content-language-add,
 body:not([data-dialog="language-change"]) #dialog-title-language-change,
-body:not([data-dialog="language-change"]) #dialog-content-language-change,
+body:not([data-dialog="language-add"]):not([data-dialog="language-change"]) #dialog-content-language-add,
+body:not([data-dialog="language-add"]) #dialog-body button.add,
+body:not([data-dialog="language-change"]) #dialog-body button.change,
 body:not([data-dialog="predefined"]) #dialog-title-predefined,
 body:not([data-dialog="predefined"]) #dialog-content-predefined,
 body:not([data-dialog]) #dialog
 {
   display: none;
 }