Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: new-options.js

Issue 29478597: Issue 5326 - General tab (HTML, strings and functionality) (Closed)
Left Patch Set: Created Aug. 22, 2017, 4:58 p.m.
Right Patch Set: rebase Created Aug. 23, 2017, 12:36 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « new-options.html ('k') | skin/new-options.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 listItem.setAttribute("role", "section"); 134 listItem.setAttribute("role", "section");
135 135
136 let tooltip = listItem.querySelector("[data-tooltip]"); 136 let tooltip = listItem.querySelector("[data-tooltip]");
137 if (tooltip) 137 if (tooltip)
138 { 138 {
139 let tooltipId = tooltip.getAttribute("data-tooltip"); 139 let tooltipId = tooltip.getAttribute("data-tooltip");
140 tooltipId = tooltipId.replace("%value%", item.recommended); 140 tooltipId = tooltipId.replace("%value%", item.recommended);
141 if (getMessage(tooltipId)) 141 if (getMessage(tooltipId))
142 { 142 {
143 tooltip.setAttribute("data-tooltip", tooltipId); 143 tooltip.setAttribute("data-tooltip", tooltipId);
144 }
145 else
146 {
147 tooltip.parentNode.removeChild(tooltip);
148 } 144 }
149 } 145 }
150 146
151 for (let control of listItem.querySelectorAll(".control")) 147 for (let control of listItem.querySelectorAll(".control"))
152 { 148 {
153 if (control.hasAttribute("title")) 149 if (control.hasAttribute("title"))
154 { 150 {
155 let titleValue = getMessage(control.getAttribute("title")); 151 let titleValue = getMessage(control.getAttribute("title"));
156 control.setAttribute("title", titleValue); 152 control.setAttribute("title", titleValue);
157 } 153 }
(...skipping 1213 matching lines...) Expand 10 before | Expand all | Expand 10 after
1371 }); 1367 });
1372 ext.backgroundPage.sendMessage({ 1368 ext.backgroundPage.sendMessage({
1373 type: "subscriptions.listen", 1369 type: "subscriptions.listen",
1374 filter: ["added", "disabled", "homepage", "lastDownload", "removed", 1370 filter: ["added", "disabled", "homepage", "lastDownload", "removed",
1375 "title", "downloadStatus", "downloading"] 1371 "title", "downloadStatus", "downloading"]
1376 }); 1372 });
1377 1373
1378 window.addEventListener("DOMContentLoaded", onDOMLoaded, false); 1374 window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
1379 window.addEventListener("hashchange", onHashChange, false); 1375 window.addEventListener("hashchange", onHashChange, false);
1380 } 1376 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld