Issue 5374 - Add filter list popup

skin/new-options.css

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 442 matching lines @@
   color: #3A7BA6;
   text-align: center;
 }
 
 .icon,
 button[role="checkbox"],
 .table button.delete,
 #content-help a::before,
 #dialog-close::before,
 #custom-filters-add button::after,
-#dialog-body button::before,
+#dialog-body button:not([role="checkbox"])::before,
 .date::before,
 .time::before,
 #all-filter-lists .arrow,
 .context-menu .content a::before
 {
   background-image: url(options-sprite.png);
   display: inline-block;
 }
 
 .icon-add,
@@ skipping 48 matching lines @@
 #dialog-close::before,
 .date::before,
 .time::before
 {
   content: "";
   height: 12px;
   width: 12px;
 }
 
 #content-help a::before,
-#dialog-body button::before
+#dialog-body button:not([role="checkbox"])::before
 {
   background-position: 0px -42px;
   content: "";
   cursor: pointer;
   height: 11px;
   vertical-align: middle;
   width: 7px;
   -moz-margin-end: 12px;
   -webkit-margin-end: 12px;
 }
@@ skipping 625 matching lines @@
   vertical-align: middle;
   -moz-margin-end: 6px;
   -webkit-margin-end: 6px;
 }
 
 #dialog #dialog-body
 {
   margin: 4px 24px;
 }
 
+#recommended-general-ads-block

[Thomas Greiner, 2017/07/25 10:30:54]

Detail: That's a very specific selector for a pretty generic scrollable element.
So what about turning this into a class for making an element scrollable?

[saroyanm, 2017/07/28 17:54:55]

I'll update that.

+{
+  max-height: 400px;

[Thomas Greiner, 2017/07/25 10:30:54]

Detail: I couldn't find this number anywhere in the spec. Where does it come
from?

[saroyanm, 2017/07/28 17:54:54]

CSS will be updated completely in separate review according to styleguide.
This styles are only for visually make the list scrollable.

+  overflow: auto;
+}
+
 #dialog h3,
 #dialog label
 {
   font-size: 14px;
   font-weight: 600;
   margin: 0px;
 }
 
 #dialog input[type="text"],
 #dialog input[type="search"]
@@ skipping 26 matching lines @@
   flex: 1;
   font-size: 16px;
   color: #FFFFFF;
 }
 
 #dialog-body .dialog-content-block
 {
   padding: 12px 0px;
 }
 
-#dialog-body button
+#dialog-body button:not([role="checkbox"])
 {
   background-color: #F5F5F5;
   border: none;
   color: #3A7BA6;
   cursor: pointer;
   display: block;
   font-family: inherit;
   margin-top: 8px;
   padding: 10px 16px;
   text-align: initial;
   width: 100%;
 }
 
 #dialog .url
 {
   margin-top: 10px;
   margin-bottom: 20px;
   word-wrap: break-word;
 }
 
+body:not([data-dialog="recommended"]) #dialog-title-recommended,
+body:not([data-dialog="recommended"]) #dialog-content-recommended,
 body:not([data-dialog="custom"]) #dialog-title-custom,
 body:not([data-dialog="custom"]) #dialog-content-custom,
 body:not([data-dialog="language"]) #dialog-title-language,
 body:not([data-dialog="language"]) #dialog-content-language,
 body:not([data-dialog="predefined"]) #dialog-title-predefined,
 body:not([data-dialog="predefined"]) #dialog-content-predefined,
 body:not([data-dialog]) #dialog
 {
   display: none;
 }
@@ skipping 27 matching lines @@
 #other-language .button-add::before
 {
   display: none;
 }
 
 #other-language .display
 {
   -webkit-margin-start: 10px;
   -moz-margin-start: 10px;
 }