Unified Diff: new-options.html
Issue 29480624:
Issue 5374 - Add filter list popup (Closed)
Patch Set:
Created July 7, 2017, 6:12 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« locale/en-US/new-options.json ('K')
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
new-options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: new-options.html |
| =================================================================== |
| --- a/new-options.html |
| +++ b/new-options.html |
| @@ -275,7 +275,7 @@ |
| </li> |
| </ul> |
| <div class="controls"> |
| - <button data-action="open-dialog" data-dialog="custom"> |
| + <button data-action="open-dialog" data-dialog="recommended"> |
| <span class="icon icon-add"></span> |
| <span class="i18n_options_filterList_add"></span> |
| </button> |
| @@ -360,6 +360,7 @@ |
| <div id="dialog" role="dialog" aria-hidden="true"> |
| <header> |
| <span id="dialog-title"> |
| + <span id="dialog-title-recommended" class="i18n_options_dialog_recommended_title"></span> |
| <span id="dialog-title-custom" class="i18n_options_dialog_custom_title"></span> |
| <span id="dialog-title-language" class="i18n_options_dialog_language_title"></span> |
| <span id="dialog-title-predefined" class="i18n_options_dialog_predefined_title"></span> |
| @@ -367,6 +368,31 @@ |
| <button id="dialog-close" class="i18n_options_close focus-first" data-action="close-dialog"></button> |
| </header> |
| <div id="dialog-body" class="content"> |
| + <!-- Add recommended subscription --> |
| + <div id="dialog-content-recommended" class="dialog-content"> |
| + <div id="recommended-general-ads-block"> |
| + <div class="dialog-content-block"> |
| + <h3 class="i18n_options_dialog_recommended_general"></h3> |
| + <ul id="recommend-general-list-table" class="table list"> |
|
saroyanm
2017/07/10 13:00:05
As discussed already, we do not need to introduce
saroyanm
2017/07/13 17:09:22
Product, agreed on introducing this anyway if it's
Thomas Greiner
2017/07/25 10:30:54
It's no longer in the spec, however.
saroyanm
2017/07/28 17:54:54
I'll remove this.
|
| + <template> |
| + <button data-action="add-enable-subscription" role="checkbox" class="control"></button> |
|
Thomas Greiner
2017/07/25 10:30:54
The entire row should be clickable, not just the i
saroyanm
2017/07/28 17:54:54
I agree, I'll update it in current review.
|
| + <label class="display"></label> |
| + <span class="description"></span> |
| + </template> |
| + </ul> |
| + </div> |
| + <div class="dialog-content-block"> |
| + <ul id="recommend-ads-list-table" class="table list"> |
| + <template> |
| + <button data-action="add-enable-subscription" role="checkbox" class="control"></button> |
| + <label class="display"></label> |
| + <span class="description"></span> |
| + </template> |
| + </ul> |
| + </div> |
| + </div> |
| + <button class="i18n_options_filter_by_url" data-action="close-dialog,open-dialog" data-dialog="custom"></button> |
|
Thomas Greiner
2017/07/25 10:30:54
I'd argue that "open-dialog" should automatically
saroyanm
2017/07/28 17:54:54
I agree, I'll add dialog management in current rev
|
| + </div> |
| <!-- Add language subscription --> |
|
Thomas Greiner
2017/07/25 10:30:54
I thought we wanted to replace this dialog with th
saroyanm
2017/07/28 17:54:54
What you mean by new one ?
Sidenote: This is diffe
|
| <div id="dialog-content-language" class="dialog-content"> |
| <div class="dialog-content-block"> |
| @@ -384,7 +410,7 @@ |
| </div> |
| <ul id="all-lang-table" class="table list"> |
| <template> |
| - <button data-action="add-language-subscription" class="button-add control"> |
| + <button data-action="add-enable-subscription" class="button-add control"> |
| +<span class="i18n_options_button_add"></span> |
| </button> |
| <label class="display"></label> |
« locale/en-US/new-options.json ('K')
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
new-options.js » ('J')
