includes/meta/standard.tmpl - Issue 29480630: Issue 5329 - Added standard meta data to website-defaults

Delta Between Two Patch Sets: includes/meta/standard.tmpl

Issue 29480630: Issue 5329 - Added standard meta data to website-defaults (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Left Patch Set: Created July 5, 2017, 5:34 p.m.

Right Patch Set: Removed title condition Created July 17, 2017, 10:39 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <meta charset="utf-8">	1 <meta charset="utf-8">

2 <meta http-equiv="x-ua-compatible" content="ie=edge">	2 <meta http-equiv="x-ua-compatible" content="ie=edge">

3 <meta name="viewport" content="width=device-width, initial-scale=1">	3 <meta name="viewport" content="width=device-width, initial-scale=1">

4 {% if title %}	4 <title>{{ title \| translate("page-title", "Page title") }}</title>
ire 2017/07/06 08:12:02 Question: Since these are the standard meta data t Question: Since these are the standard meta data that must be on every page, is there a way to enforce them? i.e. will things break if there is no title or description? If not, should we have some form of fallback? e.g. use the site-wide title and description if a page-specific one is not provided. This may not actually matter if the code will never pass review without having a title and description for each page. juliandoucette 2017/07/06 13:26:00 Good question. - I think title and description sh Show quoted text On 2017/07/06 08:12:02, ire wrote: > Question: Since these are the standard meta data that must be on every page, > is there a way to enforce them? i.e. will things break if there is no title or > description? If not, should we have some form of fallback? e.g. use the > site-wide title and description if a page-specific one is not provided. > > This may not actually matter if the code will never pass review without having a > title and description for each page. Good question. - I think title and description should be required - I wanted to integrate this without breaking existing websites - I don't want to block this change with the creation of a description for every page that is currently missing one Weak conclusion: They must be conditional. ire 2017/07/07 08:37:43 Okay I see, makes sense. This is probably a sugge Show quoted text On 2017/07/06 13:26:00, juliandoucette wrote: > On 2017/07/06 08:12:02, ire wrote: > > Question: Since these are the standard meta data that must be on every page, > > is there a way to enforce them? i.e. will things break if there is no title or > > description? If not, should we have some form of fallback? e.g. use the > > site-wide title and description if a page-specific one is not provided. > > > > This may not actually matter if the code will never pass review without having > a > > title and description for each page. > > Good question. > > - I think title and description should be required > - I wanted to integrate this without breaking existing websites > - I don't want to block this change with the creation of a description for every > page that is currently missing one > > Weak conclusion: They must be conditional. Okay I see, makes sense. This is probably a suggestion that can be dealt with in a separate issue, but do you think it would make sense to have a site-wide fallback then? For example, let's say there is no title/description for a specific page on adblockplus.org, the fallback title/description would be something applicable to the entire site, e.g. "Adblock Plus" for the title and "Surf the web without annoying ads!" for the description. Since we have a relatively small number of sites, we could add this without too much effort and guarantee that all pages of every site will have a title and description. juliandoucette 2017/07/07 11:50:16 I don't know. In (my) theory - a competent parse Show quoted text On 2017/07/07 08:37:43, ire wrote: > This is probably a suggestion that can be dealt with in a separate issue, but do > you think it would make sense to have a site-wide fallback then? I don't know. In (my) theory - a competent parser (search engine, social media) will fall back to the highest level heading (title) and the first phrasing content it can find (description) and this may be better than the site title/description because we don't want people going to specific (non-home) pages that look like home in search results / social media. - But I'm really speculating here - and I'm guessing I'm wrong about something. Do you know anything about this? ire 2017/07/12 08:22:37 From my (limited) research, I couldn't really find Show quoted text On 2017/07/07 11:50:16, juliandoucette wrote: > On 2017/07/07 08:37:43, ire wrote: > > This is probably a suggestion that can be dealt with in a separate issue, but > do > > you think it would make sense to have a site-wide fallback then? > > I don't know. > > In (my) theory - a competent parser (search engine, social media) will fall back > to the highest level heading (title) and the first phrasing content it can find > (description) and this may be better than the site title/description because we > don't want people going to specific (non-home) pages that look like home in > search results / social media. - But I'm really speculating here - and I'm > guessing I'm wrong about something. > > Do you know anything about this? From my (limited) research, I couldn't really find anything to support this fallback behaviour. Additionally, according to the HTML spec, a title element is required in most circumstances (http://w3c.github.io/html/single-page.html#the-head-element) and a page will fail validation if it is not included. I don't think this is the same for description though. So perhaps a fallback would be necessary for the page title, but not the description. juliandoucette 2017/07/14 11:40:54 Acknowledged. I was wrong about Facebook; at leas Show quoted text On 2017/07/12 08:22:37, ire wrote: > On 2017/07/07 11:50:16, juliandoucette wrote: > > On 2017/07/07 08:37:43, ire wrote: > > > This is probably a suggestion that can be dealt with in a separate issue, > but > > do > > > you think it would make sense to have a site-wide fallback then? > > > > I don't know. > > > > In (my) theory - a competent parser (search engine, social media) will fall > back > > to the highest level heading (title) and the first phrasing content it can > find > > (description) and this may be better than the site title/description because > we > > don't want people going to specific (non-home) pages that look like home in > > search results / social media. - But I'm really speculating here - and I'm > > guessing I'm wrong about something. > > > > Do you know anything about this? > > From my (limited) research, I couldn't really find anything to support this > fallback behaviour. Additionally, according to the HTML spec, a title element is > required in most circumstances > (http://w3c.github.io/html/single-page.html#the-head-element) and a page will > fail validation if it is not included. > > I don't think this is the same for description though. So perhaps a fallback > would be necessary for the page title, but not the description. Acknowledged. I was wrong about Facebook; at least. See https://developers.facebook.com/tools/debug/sharing/?q=http%3A%2F%2Fjuliandou...
5 <title>{{ title \| translate("page-title", "Meta page title") }}</title>	5 {% if description %}

	6 <meta name="description" content="{{ description \| translate("page-description ", "Page description") }}">

6 {% endif %}	7 {% endif %}

7 {% if description %}

8 <meta name="description" content="{{ description \| translate("page-description ", "Meta page description") }}">

9 {% endif %}

LEFT	RIGHT