includes/meta/social.tmpl - Issue 29480675: Issue 5329 - Added standard social media meta data to website-defaults

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/meta/social.tmpl

Issue 29480675: Issue 5329 - Added standard social media meta data to website-defaults (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Patch Set: Created July 5, 2017, 9:43 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {# open graph #}

	2

	3 {% if host and page %}

	4 <meta property="og:url" content="{{ host }}/{{ page }}">
	juliandoucette 2017/07/05 21:47:25 Note: I created an issue to provide us with a bett Note: I created an issue to provide us with a better way to do this (instead of using a global `host`) ire 2017/07/07 16:05:06 Acknowledged. Show quoted text On 2017/07/05 21:47:25, juliandoucette wrote: > Note: I created an issue to provide us with a better way to do this (instead of > using a global `host`) Acknowledged.
	5 {% endif %}

	6 {% if og_type %}

	7 <meta property="og:type" content="{{ og_type }}">

	8 {% endif %}

	9 {% if og_site_name %}

	10 <meta property="og:site_name" content="{{ og_site_name }}">

	11 {% endif %}

	12 {% if og_title %}

	13 <meta property="og:title" content="{{ og_title }}">

	14 {% endif %}

	15 {% if og_description %}

	16 <meta property="og:descirption" content="{{ og_description }}">
	ire 2017/07/07 16:05:06 Typo in "og:descirption" Typo in "og:descirption" juliandoucette 2017/07/07 20:05:20 Done. Good eye. Show quoted text On 2017/07/07 16:05:06, ire wrote: > Typo in "og:descirption" Done. Good eye. ire 2017/07/10 07:50:57 Thanks :) Show quoted text On 2017/07/07 20:05:20, juliandoucette wrote: > On 2017/07/07 16:05:06, ire wrote: > > Typo in "og:descirption" > > Done. > > Good eye. Thanks :)
	17 {% endif %}

	18 {% if og_image %}

	19 <meta property="og:image" content="{{ og_image }}">

	20 {% else if og_site_image %}

	21 <meta property="og:image" content="{{ og_site_image }}">

	22 {% endif %}

	23 <meta property="og:locale" content="{{ locale }}">
	juliandoucette 2017/07/05 21:47:25 Note: I'm not sure if the accepted locales are the Note: I'm not sure if the accepted locales are the same as the locales we provide. ire 2017/07/07 16:05:06 Should this be wrapped in an if statement? Or is l Should this be wrapped in an if statement? Or is locale a required variable? juliandoucette 2017/07/07 20:05:20 locale is always set. A default must be set in set Show quoted text On 2017/07/07 16:05:06, ire wrote: > Should this be wrapped in an if statement? Or is locale a required variable? locale is always set. A default must be set in settings.ini. ire 2017/07/10 07:50:57 Acknowledged. Show quoted text On 2017/07/07 20:05:20, juliandoucette wrote: > On 2017/07/07 16:05:06, ire wrote: > > Should this be wrapped in an if statement? Or is locale a required variable? > > locale is always set. A default must be set in settings.ini. Acknowledged.
	24 {% for alternate_locale in locales %}

	25 {% if alternate_locale != locale %}

	26 <meta property="og:locale:alternate" content="{{ alternate_locale }}">

	27 {% endif %}

	28 {% endfor %}

	29

	30 {# twitter #}

	31

	32 {% if twitter_site %}

	33 <meta name="twitter:site" content="@{{ twitter_site }}">

	34 {% endif %}

	35 {% if twitter_card %}

	36 <meta name="twitter:card" content="{{ twitter_card }}">

	37 {% else if og_image or og_site_image %}

	38 <meta name="twitter:card" content="summary_large_image">

	39 {% else %}

	40 <meta name="twitter:card" content="summary">

	41 {% endif %}

	42 {% if twitter_image_alt %}

	43 <meta name="twitter:image:alt" content="{{ twitter_image_alt }}">

	44 {% endif %}

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »