Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29481653: Issue 5378 - Stop using of jshydra in libadblockplus (Closed)

Created:
July 6, 2017, 1:32 p.m. by sergei
Modified:
July 7, 2017, 8:12 a.m.
Reviewers:
hub
CC:
Felix Dahlke, Oleksandr, Eric
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M convert_js.py View 3 chunks +11 lines, -7 lines 0 comments Download
M lib/compat.js View 2 chunks +4 lines, -1 line 1 comment Download
M lib/io.js View 1 chunk +1 line, -1 line 1 comment Download
M lib/updater.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
sergei
https://codereview.adblockplus.org/29481653/diff/29481654/lib/compat.js File lib/compat.js (right): https://codereview.adblockplus.org/29481653/diff/29481654/lib/compat.js#newcode82 lib/compat.js:82: import: function() It's for numerous Cu.import https://codereview.adblockplus.org/29481653/diff/29481654/lib/io.js File lib/io.js ...
July 6, 2017, 1:37 p.m. (2017-07-06 13:37:02 UTC) #1
hub
July 6, 2017, 7:32 p.m. (2017-07-06 19:32:04 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld