modules/adblockplus/templates/web/redirector.conf.erb - Issue 29481679: #1975 - Introduce class adblockplus::web::redirector

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: modules/adblockplus/templates/web/redirector.conf.erb

Issue 29481679: #1975 - Introduce class adblockplus::web::redirector (Closed)

Patch Set: Created July 6, 2017, 4:42 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 # Puppet: <%= @title %>

	2

	3 # http://hub.eyeo.com/issues/1975

	4 location /

	5 {

	6 <%- @targets.sort.each do \|key, target\| -%>

	7 rewrite ^/<%= key %>(/.*)?$ "<%= target %>" break;
	Fred 2017/07/06 17:17:27 Didn't we want to append the original query string Didn't we want to append the original query string to the redirect target URL? mathias 2017/07/06 17:23:54 We do. That is the default behavior of the Nginx r Show quoted text On 2017/07/06 17:17:27, Fred wrote: > Didn't we want to append the original query string to the redirect target URL? We do. That is the default behavior of the Nginx rewrite directive in this case: $ wget --server-response --spider eyeo.to/jobs/test?foo=bar 2>&1 \| grep ^-- --2017-07-06 17:22:12-- http://eyeo.to/jobs/test?foo=bar --2017-07-06 17:22:12-- https://eyeo.com/en/jobs?foo=bar --2017-07-06 17:22:12-- https://eyeo.com/en/jobs/?foo=bar
	8 <%- end -%>

	9 rewrite ^/.*$ "<%= @default %>" last;

	10 }

	11

OLD	NEW