Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29481700: Issue 5339 - Properly select element for pseudo-element (Closed)

Created:
July 6, 2017, 8:16 p.m. by hub
Modified:
Aug. 10, 2017, 2:24 p.m.
Reviewers:
Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5339 - Properly select element for pseudo-element

Patch Set 1 #

Patch Set 2 : Reworked based on the new implementation proposal. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/content/elemHideEmulation.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/browser/elemHideEmulation.js View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5
hub
July 6, 2017, 8:16 p.m. (2017-07-06 20:16:04 UTC) #1
hub
See issue #5000 for a practical example that actually work. https://issues.adblockplus.org/ticket/5000
July 24, 2017, 9:18 p.m. (2017-07-24 21:18:11 UTC) #2
Wladimir Palant
I'm not convinced that this is the right approach. See https://issues.adblockplus.org/ticket/5339#comment:10 - what do you ...
Aug. 8, 2017, 11:20 a.m. (2017-08-08 11:20:45 UTC) #3
hub
On 2017/08/08 11:20:45, Wladimir Palant wrote: > I'm not convinced that this is the right ...
Aug. 8, 2017, 4:58 p.m. (2017-08-08 16:58:15 UTC) #4
Wladimir Palant
Aug. 10, 2017, 1:57 p.m. (2017-08-10 13:57:04 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld