Noissue - Use buffer for FileSystem IO

test/Prefs.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 11 matching lines @@
 
 using namespace AdblockPlus;
 
 namespace
 {
   typedef std::shared_ptr<AdblockPlus::FilterEngine> FilterEnginePtr;
 
   class TestFileSystem : public LazyFileSystem
   {
   public:
-    std::string prefsContents;
+    IOBuffer prefsContents;
 
-    std::shared_ptr<std::istream> Read(const std::string& path) const
+    IOBuffer Read(const std::string& path) const
     {
       if (path == "prefs.json" && !prefsContents.empty())
-        return std::shared_ptr<std::istream>(new std::istringstream(prefsContents));
+        return prefsContents;
 
       return LazyFileSystem::Read(path);
     }
 
-    void Write(const std::string& path, std::istream& content)
+    void Write(const std::string& path, const IOBuffer& content)
     {
       if (path == "prefs.json")
-      {
-        std::stringstream ss;
-        ss << content.rdbuf();
-        prefsContents = ss.str();
-      }
+        prefsContents = content;
       else
         LazyFileSystem::Write(path, content);
     }
 
     StatResult Stat(const std::string& path) const
     {
       if (path == "prefs.json")
       {
         StatResult result;
         result.exists = result.isFile = !prefsContents.empty();
@@ skipping 77 matching lines @@
     ResetJsEngine();
     auto filterEngine = CreateFilterEngine();
     ASSERT_EQ("filters.ini", filterEngine->GetPref("patternsfile").AsString());
     ASSERT_EQ(48, filterEngine->GetPref("patternsbackupinterval").AsInt());
     ASSERT_FALSE(filterEngine->GetPref("subscriptions_autoupdate").AsBool());
   }
 }
 
 TEST_F(PrefsTest, UnknownPrefs)
 {
-  fileSystem->prefsContents = "{\"foobar\":2, \"patternsbackupinterval\": 12}";
+  using IOBuffer = AdblockPlus::FileSystem::IOBuffer;
+  std::string content = "{\"foobar\":2, \"patternsbackupinterval\": 12}";
+  fileSystem->prefsContents = IOBuffer(content.cbegin(), content.cend());
   auto filterEngine = CreateFilterEngine();
   ASSERT_TRUE(filterEngine->GetPref("foobar").IsUndefined());
   ASSERT_EQ(12, filterEngine->GetPref("patternsbackupinterval").AsInt());
 }
 
 TEST_F(PrefsTest, SyntaxFailure)
 {
-  fileSystem->prefsContents = "{\"patternsbackupinterval\": 6, \"foo\"}";
+  using IOBuffer = AdblockPlus::FileSystem::IOBuffer;
+  std::string content = "{\"patternsbackupinterval\": 6, \"foo\"}";
+  fileSystem->prefsContents = IOBuffer(content.cbegin(), content.cend());
   auto filterEngine = CreateFilterEngine();
 
   ASSERT_EQ(24, filterEngine->GetPref("patternsbackupinterval").AsInt());
 }
 
 TEST_F(PrefsTest, PreconfiguredPrefsPreconfigured)
 {
   AdblockPlus::FilterEngine::Prefs preconfiguredPrefs;
   preconfiguredPrefs.emplace("disable_auto_updates", jsEngine->NewValue(false));
   preconfiguredPrefs.emplace("suppress_first_run_page", jsEngine->NewValue(true));
@@ skipping 43 matching lines @@
   {
     ResetJsEngine();
     AdblockPlus::FilterEngine::Prefs preconfiguredPrefs;
     preconfiguredPrefs.emplace("suppress_first_run_page", jsEngine->NewValue(true));
     auto filterEngine = CreateFilterEngine(preconfiguredPrefs);
 
     ASSERT_TRUE(filterEngine->GetPref("suppress_first_run_page").IsBool());
     ASSERT_FALSE(filterEngine->GetPref("suppress_first_run_page").AsBool());
   }
 }