Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/DefaultFileSystem.h

Issue 29481704: Noissue - Use buffer for FileSystem IO (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Nit addressed Created July 7, 2017, 12:50 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/FileSystem.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/DefaultFileSystem.h
===================================================================
--- a/include/AdblockPlus/DefaultFileSystem.h
+++ b/include/AdblockPlus/DefaultFileSystem.h
@@ -32,18 +32,18 @@
* `FileSystem` implementation that interacts directly with the operating
* system's file system.
* All paths are considered relative to the base path, or to the current
* working directory if no base path is set (see `SetBasePath()`).
*/
class DefaultFileSystem : public FileSystem
{
public:
- std::shared_ptr<std::istream> Read(const std::string& path) const;
- void Write(const std::string& path, std::istream& data);
+ IOBuffer Read(const std::string& path) const;
+ void Write(const std::string& path, const IOBuffer& data);
void Move(const std::string& fromPath, const std::string& toPath);
void Remove(const std::string& path);
StatResult Stat(const std::string& path) const;
std::string Resolve(const std::string& path) const;
/**
* Sets the base path, all paths are considered relative to it.
* @param path Base path.
« no previous file with comments | « no previous file | include/AdblockPlus/FileSystem.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld