Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: ext/content.js

Issue 29482663: Issue 5386 - Ignore messages from content scripts in devtools panel (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Use includes instead of indexOf Created Aug. 16, 2017, 10:29 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 "use strict"; 1 "use strict";
2 2
3 chrome.runtime.onMessage.addListener((message, sender, sendResponse) => 3 // Firefox 55 erroneously sends messages from the content script to the
4 // devtools panel:
5 // https://bugzilla.mozilla.org/show_bug.cgi?id=1383310
6 // As a workaround, listen for messages only if this isn't the devtools panel.
7 if (!("devtools" in chrome))
4 { 8 {
5 return ext.onMessage._dispatch(message, {}, sendResponse).indexOf(true) != -1; 9 // Listen for messages from the background page.
6 }); 10 chrome.runtime.onMessage.addListener((message, sender, sendResponse) =>
11 {
12 return ext.onMessage._dispatch(message, {}, sendResponse).includes(true);
13 });
14 }
7 15
8 (function() 16 (function()
9 { 17 {
10 let port = null; 18 let port = null;
11 19
12 ext.onExtensionUnloaded = { 20 ext.onExtensionUnloaded = {
13 addListener(listener) 21 addListener(listener)
14 { 22 {
15 if (!port) 23 if (!port)
16 port = chrome.runtime.connect(); 24 port = chrome.runtime.connect();
(...skipping 10 matching lines...) Expand all
27 35
28 if (!port.onDisconnect.hasListeners()) 36 if (!port.onDisconnect.hasListeners())
29 { 37 {
30 port.disconnect(); 38 port.disconnect();
31 port = null; 39 port = null;
32 } 40 }
33 } 41 }
34 } 42 }
35 }; 43 };
36 }()); 44 }());
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld