hiera/roles/web/adblockplus.yaml - Issue 29483575: #2007 - Create abp::legacy::webserver class for hiera compatibility

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: hiera/roles/web/adblockplus.yaml

Issue 29483575: #2007 - Create abp::legacy::webserver class for hiera compatibility (Closed)

Left Patch Set: Creates a full commit for refactoring webserver manifest Created July 10, 2017, 6:29 p.m.

Right Patch Set: For comment 9 and 10 Created July 12, 2017, 7:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 classes:	1 classes:

2 nodejs:	2 nodejs:

3 adblockplus::legacy::webserver:	3 adblockplus::legacy::webserver:

4 adblockplus::log:	4 adblockplus::log:

5

6 adblockplus::packages:
mathias 2017/07/12 16:13:46 Both make and doxygen are actual requirements for Both make and doxygen are actual requirements for something configured in the manifest, hence they should be ensured in that context. f.lopez 2017/07/12 16:25:59 Acknowledged. Show quoted text On 2017/07/12 16:13:46, mathias wrote: > Both make and doxygen are actual requirements for something configured in the > manifest, hence they should be ensured in that context. Acknowledged.
7 - make

8 - doxygen

9	5

10 adblockplus::log::rotations:	6 adblockplus::log::rotations:

11 nginx_email_submission:	7 nginx_email_submission:

12 count: 120	8 count: 120

13 ensure: present	9 ensure: present

14 interval: monthly	10 interval: monthly

15 path: /var/log/nginx/email_submission	11 path: /var/log/nginx/email_submission

16	12

17 nodejs::packages:	13 nodejs::packages:

18 jsdoc:	14 jsdoc:

19 options:
mathias 2017/07/12 16:13:46 Aren't options obsolete now? Aren't options obsolete now? f.lopez 2017/07/12 16:25:59 Acknowledged. Show quoted text On 2017/07/12 16:13:46, mathias wrote: > Aren't options obsolete now? Acknowledged.
20 - --global

21	15

22 sitescripts::configfragments:	16 sitescripts::configfragments:

23 formmail_template:	17 formmail_template:

24 content: \|	18 content: \|

25 [multiplexer]	19 [multiplexer]

26 sitescripts.subscriptions.web.fallback =	20 sitescripts.subscriptions.web.fallback =

27 [subscriptions]	21 [subscriptions]

28 repository=/opt/sitescripts/sitescripts/subscriptionlist	22 repository=/home/www/subscriptionlist

29	23

LEFT	RIGHT