#2007 - Introduce nodejs module

modules/nodejs/manifests/init.pp

 # == Class: nodejs
 #
-# Install nodejs package from source
+# Install nodejs package from NodeSource
 #
 # == Parameters:
 #
 # [*package*]
 #   Overwrite the default package options, to fine-tune the target version (i.e.
 #   ensure => 'latest') or remove nodejs (ensure => 'absent' or 'purged')
 #
 # [*key*]
 #   Overwrite the default apt::key used (given Class['apt'] is defined).
 #
@@ skipping 19 matching lines @@
   },
   $package = {},
   $source = {
     location => 'https://deb.nodesource.com/node_4.x',
     release => downcase($lsbdistcodename),
     repos => 'main',
   },
   $packages = {},
 ) {
 
-  include stdlib
+  if ensure_state($ensure) {
+    $ensure = 'present'
+  }
+  else {
+    $ensure = 'absent'
+  }
 
   ensure_resource('package', $title, merge({
     name => $title,
-    require => Apt::Source[$title],

[mathias, 2017/07/09 07:26:50]

Use arrow-notation to establish relationships, especially when using this merge
magic. Otherwise the configuration could overwrite your definitions by accident.

(BTW, this very relationship is already configured properly below.)

     ensure => $ensure,
   }, $package))
 
-  # Used as default $ensure parameter for most resources below
-  $ensure = getparam(Package[$title], 'ensure') ? {
-    /^(absent|purged)$/ => 'absent',
-    default => 'present',
-  }
+  # The only package provider recognized implicitly
+  ensure_resource('apt::key', $title, merge({
+    ensure => $ensure,
+    name => 'nodesource',
+  }, $key))
 
-  if ensure_state($ensure) {
+  ensure_resource('apt::source', $title, merge({
+    ensure => $ensure,
+    include_src => false,
+    name => 'nodesource',
+  }, $source))
 
-    # The only package provider recognized implicitly
-    ensure_resource('apt::key', $title, merge({

[mathias, 2017/07/09 07:26:50]

How is the user supposed to remove this one if the package is ensured to be
'absent'?

-      ensure => $ensure,
-      name => 'nodesource',
-    }, $key))
+  Apt::Source[$title] <- Apt::Key[$title]
+  Apt::Source[$title] -> Package[$title]
 
-    ensure_resource('apt::source', $title, merge({

[mathias, 2017/07/09 07:26:50]

How is the user supposed to remove this one if the package is ensured to be
'absent'?

-      ensure => $ensure,
-      include_src => false,
-      name => 'nodesource',
-    }, $source))
+  ensure_resources('nodejs::package', $packages, {
+    ensure => 'present',
+  })
+}
 
-    Apt::Source[$title] <- Apt::Key[$title]
-    Apt::Source[$title] -> Package[$title]
-
-    create_resources('nodejs::package', $packages)
-
-  }
-
-}