includes/searchform.tmpl - Issue 29485575: Issue 5385 - Create Site Header Component for Help Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/searchform.tmpl

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)

Patch Set: Created July 10, 2017, 4:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <form id="searchform" action="">
	juliandoucette 2017/07/14 14:11:29 You can fill in the action and make this work now You can fill in the action and make this work now can't you? ire 2017/07/17 09:25:53 Done. Show quoted text On 2017/07/14 14:11:29, juliandoucette wrote: > You can fill in the action and make this work now can't you? Done.
	2 <label for="search" class="sr-only">Search Adblock Plus Help</label>
	juliandoucette 2017/07/14 14:11:29 I'm not sure this is necessary considering the pla I'm not sure this is necessary considering the placeholder, search button alt, and aria-label. What do you think? ire 2017/07/17 09:25:53 I think the label is more important that the other Show quoted text On 2017/07/14 14:11:29, juliandoucette wrote: > I'm not sure this is necessary considering the placeholder, search button alt, > and aria-label. What do you think? I think the label is more important that the others actually. When the input field is in focus, that's the text that is read out first. Although the placeholder is usually also read out, I'm not sure it is as reliable as the label itself. Following on from my comment about image alts, I think the `aria-label` might be what is overkill here.
	3 <input id="search" name="search" type="search" placeholder="Search Adblock Plu s Help">

	4 <button type="submit" aria-label="Search">

	5 <img src="img/png/searchIcon.png" srcset="img/png/searchIcon.png, img/svg/se archIcon.svg 2x" alt="Search">

	6 </button>

	7 </form>

OLD	NEW

« includes/layout/header.tmpl ('K') | « includes/layout/header.tmpl ('k') | static/img/png/eyeo-help.png » ('j') | static/js/main.js » ('J')