static/js/main.js - Issue 29485575: Issue 5385 - Create Site Header Component for Help Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: static/js/main.js

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)

Patch Set: Created July 10, 2017, 4:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 (function(){

	2 document.addEventListener("DOMContentLoaded", function()

	3 {

	4 document.getElementById('toggle-searchform').addEventListener('click', funct ion(e) {

	5 e.preventDefault();

	6 document.getElementById('site-search').classList.toggle('open');
	juliandoucette 2017/07/14 14:11:29 I don't remember if we agreed upon browser require I don't remember if we agreed upon browser requirements for this website already, but one might argue that we should support the same browsers as ABP if we are developing a help center for ABP. - https://adblockplus.org/requirements - http://caniuse.com/#search=classList Let's have a talk with Ollie about the future of IE8 support before we do anything too crazy though :D ire 2017/07/17 09:25:54 It was my impression the support was ie 9 and up a Show quoted text On 2017/07/14 14:11:29, juliandoucette wrote: > I don't remember if we agreed upon browser requirements for this website > already, but one might argue that we should support the same browsers as ABP if > we are developing a help center for ABP. > > - https://adblockplus.org/requirements > - http://caniuse.com/#search=classList > > Let's have a talk with Ollie about the future of IE8 support before we do > anything too crazy though :D It was my impression the support was ie 9 and up as is in the browserlist. Sure let's chat with Ollie to decide.
	7 }, false);

	8 }, false);

	9 }());

OLD	NEW