includes/layout/header.tmpl - Issue 29485575: Issue 5385 - Create Site Header Component for Help Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/layout/header.tmpl

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)

Patch Set: Fix svgs, Implement search, Show searchbar for no-js Created July 17, 2017, 9:24 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <header id="site-header" class="navbar">

	2 <div class="navbar-wrapper clearfix">
	juliandoucette 2017/07/19 18:03:33 I don't think we need clearfix here? --- (Unless I don't think we need clearfix here? --- (Unless we decide to move some floating elements above the site-header in the future?) ire 2017/07/21 10:23:26 You're right it's not needed. I must have added it Show quoted text On 2017/07/19 18:03:33, juliandoucette wrote: > I don't think we need clearfix here? > > --- > > (Unless we decide to move some floating elements above the site-header in the > future?) You're right it's not needed. I must have added it when I had a slightly different implementation.
	3 <h1 class="site-title">

	4 {{ "index" \| linkify() }}

	5 <img src="/img/png/eyeo-help.png" srcset="/img/png/eyeo-help.png, /img/s vg/eyeo-help.svg 2x" alt="{{ "eyeo Help" \| translate("site-title", "Image alt te xt") }}">
	juliandoucette 2017/07/19 18:03:33 I don't think we need the first /img/png/eyeo-help I don't think we need the first /img/png/eyeo-help.png in srcset? ire 2017/07/21 10:23:25 Done. Show quoted text On 2017/07/19 18:03:33, juliandoucette wrote: > I don't think we need the first /img/png/eyeo-help.png in srcset? Done.
	6 </a>

	7 </h1>

	8 <button id="toggle-searchform" class="unstyled tablet-and-mobile-only">
	juliandoucette 2017/07/19 18:03:32 I think this control is misleading. This button to I think this control is misleading. This button toggles a menu that contains a search form and an external link. If our intention is to toggle a menu, I would suggest a menu icon (hamburger) and alike alt-text. If our intention is to toggle a search form, I would suggest expanding this search form out of the search icon to the right (above the site logo which would fade out during).
	9 <img src="/img/png/searchIcon.png" srcset="/img/png/searchIcon.png, /img/s vg/searchIcon.svg 2x" alt="{{ "Toggle Search Bar" \| translate("search-toggle-alt ", "Image alt text") }}">
	juliandoucette 2017/07/19 18:03:32 NIT: Please use dashes in image names. NIT: Please use dashes in image names. juliandoucette 2017/07/19 18:03:33 1x image is poor quality on low DPI screens. I thi 1x image is poor quality on low DPI screens. I think we can make this crisper and/or use real text for "eye/o \| help" (keeping in mind that we can't promise fonts will be downloaded quickly or applied). ire 2017/07/21 10:23:25 Done. Show quoted text On 2017/07/19 18:03:32, juliandoucette wrote: > NIT: Please use dashes in image names. Done.
	10 </button>

	11 <div id="site-search">

	12 <? include searchform ?>

	13 <a id="product-website-link" href="https://adblockplus.org/">{{ "Adblock P lus" \| translate("abp-product-link", "Link") }}</a>
	juliandoucette 2017/07/19 18:03:32 NIT: I think this should have a `nav` around it; t NIT: I think this should have a `nav` around it; technically :/ juliandoucette 2017/07/19 18:03:33 Missing icon. Missing icon. ire 2017/07/21 10:23:25 Done. Show quoted text On 2017/07/19 18:03:32, juliandoucette wrote: > NIT: I think this should have a `nav` around it; technically :/ Done.
	14 </div>

	15 </div>

	16 </header>

OLD	NEW

« no previous file with comments | « no previous file | includes/searchform.tmpl » ('j') | includes/searchform.tmpl » ('J')