includes/searchform.tmpl - Issue 29485575: Issue 5385 - Create Site Header Component for Help Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/searchform.tmpl

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)

Patch Set: Fix svgs, Implement search, Show searchbar for no-js Created July 17, 2017, 9:24 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <form id="searchform" action="https://duckduckgo.com" method="GET">

	2 <label for="search" class="sr-only">{{ "Search Adblock Plus Help" \| translate( "searchform-label", "Label") }}</label>

	3 <input id="search" name="q" type="search" placeholder="{{ "Search Adblock Plus Help" \| translate("searchform-label", "Label") }}">

	4 <input type="hidden" name="sites" value="adblockplus.org">

	5 <button type="submit">

	6 <img src="/img/png/searchIcon.png" srcset="/img/png/searchIcon.png, /img/svg /searchIcon.svg 2x" alt="{{ "Search" \| translate("search-icon-alt", "Image alt t ext") }}">
	juliandoucette 2017/07/19 18:03:33 NIT: I wonder if "Submit (search\|query)" makes mor NIT: I wonder if "Submit (search\|query)" makes more sense (or if they are both equally fine) considering the label above. ire 2017/07/21 10:23:26 I think the submit buttons on most search forms ju Show quoted text On 2017/07/19 18:03:33, juliandoucette wrote: > NIT: I wonder if "Submit (search\|query)" makes more sense (or if they are both > equally fine) considering the label above. I think the submit buttons on most search forms just say "Search" juliandoucette 2017/07/24 21:08:07 Acknowledged. Show quoted text On 2017/07/21 10:23:26, ire wrote: > On 2017/07/19 18:03:33, juliandoucette wrote: > > NIT: I wonder if "Submit (search\|query)" makes more sense (or if they are both > > equally fine) considering the label above. > > I think the submit buttons on most search forms just say "Search" Acknowledged.
	7 </button>

	8 </form>

OLD	NEW

« includes/layout/header.tmpl ('K') | « includes/layout/header.tmpl ('k') | static/img/png/eyeo-help.png » ('j') | static/scss/base/_font.scss » ('J')