Issue 5385 - Create Site Header Component for Help Center

static/scss/components/_searchform.scss

+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
+
+#site-search
+{
+  clear: both;
+  width: 100%;

[juliandoucette, 2017/07/19 18:03:36]

NIT: I think this width is unnecessary? 

[ire, 2017/07/21 10:23:29]

Done.

+
+  &:not(.open)

[juliandoucette, 2017/07/19 18:03:35]

NIT: I think it may be clearer if we just make display:none by default and
display:block in #site-search.open.

[ire, 2017/07/21 10:23:28]

Done.

+  {
+    display: none;
+  }
+
+  @media (min-width: $tablet-breakpoint)
+  {
+    clear: none;
+    width: auto;
+
+    &:not(.open)
+    {
+      display: block;
+    }
+  }
+}
+
+.no-js #site-search
+{
+  display: block;
+}
+
+// Product Website Link
+
+#product-website-link
+{
+  float: right;
+}
+
+#site-search.open #product-website-link,
+.no-js #product-website-link

[juliandoucette, 2017/07/19 18:03:35]

I think this is misleading as .no-js #product-website-link is display:none.

[ire, 2017/07/21 10:23:28]

I don't understand. `.no-js #product-website-link` is not `display:none`?

[juliandoucette, 2017/07/24 21:08:08]

Acknowledged.

I don't know what I was thinking :/

+{
+  float: none;
+
+  @media (min-width: $mobile-breakpoint)
+  {
+    float: right;
+    margin-top: 20px;
+  }
+
+  @media (min-width: $tablet-breakpoint)
+  {
+    margin-top: 0;
+  }
+}
+
+// Search Form
+
+#searchform
+{
+  display: inline-block;
+  position: relative;
+  overflow: hidden;
+  width: 100%;
+  height: $searchform-height;
+  border-radius: 3px;
+  color: $gray;
+  background: #fff;
+  line-height: 1;
+  vertical-align: middle;

[juliandoucette, 2017/07/19 18:03:36]

Should every child of `.navbar` be vertical-align middle?

[ire, 2017/07/21 10:23:28]

No, considering my comment about .navbar also being used for the footer. 

+
+  @media (min-width: $mobile-breakpoint)
+  {
+    max-width: $searchform-width;

[juliandoucette, 2017/07/19 18:03:35]

NIT/Suggest: $search-max-width

[ire, 2017/07/21 10:23:28]

I'm not sure about this. On mobile, the search form does get bigger than this
size since it becomes 100%

+  }
+}
+
+#site-search.open #searchform,

[juliandoucette, 2017/07/19 18:03:37]

It seems like this should apply to a container of #searchform and
#product-website-link rather than each of them individually.

[ire, 2017/07/21 10:23:27]

The margin-top on both these elements, although they are the same, are actually
serving different purposes. The top margin on the #searchform is providing space
between it and the logo. The top margin on the #product-website-link is to align
the text to the bottom line of the search form.

+.no-js #searchform
+{
+  margin-top: 20px;
+
+  @media (min-width: $tablet-breakpoint)
+  {
+    margin-top: 0;
+  }
+}
+
+#searchform input
+{
+  width: 100%;
+  height: $searchform-height - 2px;
+  padding-right: $searchform-height + 5px;
+  padding-left: 10px;
+  border: 0;
+  font-family: $primary-font;
+  font-size: $small-font;
+}
+
+#searchform button
+{
+  position: absolute;
+  top: 0;
+  right: 0;
+  width: $searchform-height;
+  height: 100%;
+  border: 0;
+  background-color: transparent;
+}
+
+#searchform button img
+{
+  height: 15px;
+}
+
+html[dir="rtl"]
+{
+  #searchform input
+  {
+    padding-right: 10px;
+    padding-left: $searchform-height + 5px;
+  }
+
+  #searchform button
+  {
+    right: auto;
+    left: 0;
+  }
+
+  #product-website-link
+  {
+    float: left;
+  }
+}