static/scss/layout/_body.scss - Issue 29485575: Issue 5385 - Create Site Header Component for Help Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: static/scss/layout/_body.scss

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)

Patch Set: Fix svgs, Implement search, Show searchbar for no-js Created July 17, 2017, 9:24 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // This file is part of help.eyeo.com.

	2 // Copyright (C) 2017 Eyeo GmbH

	3 //

	4 // help.eyeo.com is free software: you can redistribute it and/or modify

	5 // it under the terms of the GNU General Public License as published by

	6 // the Free Software Foundation, either version 3 of the License, or

	7 // (at your option) any later version.

	8 //

	9 // help.eyeo.com is distributed in the hope that it will be useful,

	10 // but WITHOUT ANY WARRANTY; without even the implied warranty of

	11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	12 // GNU General Public License for more details.

	13 //

	14 // You should have received a copy of the GNU General Public License

	15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.

	16

	17 .outer

	18 {

	19 min-height: 100vh; // For testing purposes. Will remove.
	juliandoucette 2017/07/19 18:03:37 Ack. Seems like this should be part of another co Ack. Seems like this should be part of another commit. ire 2017/07/21 10:23:29 You're referring to the min-height style right? Th Show quoted text On 2017/07/19 18:03:37, juliandoucette wrote: > Ack. > > Seems like this should be part of another commit. You're referring to the min-height style right? This will be removed before I commit this patch. It shouldn't be part of any commit, or am I misunderstanding what you're saying? juliandoucette 2017/07/24 21:08:08 Acknowledged. Show quoted text On 2017/07/21 10:23:29, ire wrote: > On 2017/07/19 18:03:37, juliandoucette wrote: > > Ack. > > > > Seems like this should be part of another commit. > > You're referring to the min-height style right? This will be removed before I > commit this patch. It shouldn't be part of any commit, or am I misunderstanding > what you're saying? Acknowledged.
	20 margin-top: $site-header-height;

	21 }

OLD	NEW

« static/scss/content/_typography.scss ('K') | « static/scss/content/_typography.scss ('k') | static/scss/layout/_header.scss » ('j') | static/scss/layout/_header.scss » ('J')