includes/search-form.tmpl - Issue 29485575: Issue 5385 - Create Site Header Component for Help Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/search-form.tmpl

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)

Patch Set: Unfix header, implement standard spacing units Created Aug. 16, 2017, 2:37 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <form id="search-form" action="https://duckduckgo.com" method="GET">
	juliandoucette 2017/08/18 15:03:55 Note: Regarding size differences between the imple Note: Regarding size differences between the implementation and the mockup: These are not black and white because the images provided are obviously too big (the full width of the design cannot fit on a standard loptop screen at 100% zoom). I think we should request a 1280x800 rendering. But this kind of polishing doesn't have to block the review. We can push without addressing NITs as long as we document them in low priority tickets. ire 2017/08/21 15:23:19 Ack. Will address this in a different issue Show quoted text On 2017/08/18 15:03:55, juliandoucette wrote: > Note: Regarding size differences between the implementation and the mockup: > These are not black and white because the images provided are obviously too big > (the full width of the design cannot fit on a standard loptop screen at 100% > zoom). I think we should request a 1280x800 rendering. But this kind of > polishing doesn't have to block the review. We can push without addressing NITs > as long as we document them in low priority tickets. Ack. Will address this in a different issue juliandoucette 2017/08/21 16:28:39 Acknowledged. Show quoted text On 2017/08/21 15:23:19, ire wrote: > On 2017/08/18 15:03:55, juliandoucette wrote: > > Note: Regarding size differences between the implementation and the mockup: > > These are not black and white because the images provided are obviously too > big > > (the full width of the design cannot fit on a standard loptop screen at 100% > > zoom). I think we should request a 1280x800 rendering. But this kind of > > polishing doesn't have to block the review. We can push without addressing > NITs > > as long as we document them in low priority tickets. > > Ack. Will address this in a different issue Acknowledged.
	2 <label for="search" class="sr-only">{{ "Search Adblock Plus Help" \| translate( "search-form-label", "Label") }}</label>

	3 <input id="search" name="q" type="search" placeholder="{{ "Search Adblock Plus Help" \| translate("search-form-label", "Label") }}">
	juliandoucette 2017/08/18 15:03:55 NIT: The placeholder text is not properly centered NIT: The placeholder text is not properly centered on my screen [debian, chromium, lowdpi] ire 2017/08/21 15:23:19 Centered within the input? It isn't supposed to be Show quoted text On 2017/08/18 15:03:55, juliandoucette wrote: > NIT: The placeholder text is not properly centered on my screen [debian, > chromium, lowdpi] Centered within the input? It isn't supposed to be centered, it is aligned left. juliandoucette 2017/08/21 16:28:39 Sorry. I meant vertically. Show quoted text On 2017/08/21 15:23:19, ire wrote: > On 2017/08/18 15:03:55, juliandoucette wrote: > > NIT: The placeholder text is not properly centered on my screen [debian, > > chromium, lowdpi] > > Centered within the input? It isn't supposed to be centered, it is aligned left. Sorry. I meant vertically. ire 2017/08/22 12:15:15 Acknowledged. Show quoted text On 2017/08/21 16:28:39, juliandoucette wrote: > On 2017/08/21 15:23:19, ire wrote: > > On 2017/08/18 15:03:55, juliandoucette wrote: > > > NIT: The placeholder text is not properly centered on my screen [debian, > > > chromium, lowdpi] > > > > Centered within the input? It isn't supposed to be centered, it is aligned > left. > > Sorry. I meant vertically. Acknowledged.
	4 <input type="hidden" name="sites" value="adblockplus.org">
	juliandoucette 2017/08/18 15:03:55 NIT: I think there is more border radius in the mo NIT: I think there is more border radius in the mockup. ire 2017/08/21 15:23:19 Done. It was 1px more round :) Show quoted text On 2017/08/18 15:03:55, juliandoucette wrote: > NIT: I think there is more border radius in the mockup. Done. It was 1px more round :) juliandoucette 2017/08/21 16:28:39 Acknowledged. I wasn't sure. Show quoted text On 2017/08/21 15:23:19, ire wrote: > On 2017/08/18 15:03:55, juliandoucette wrote: > > NIT: I think there is more border radius in the mockup. > > Done. It was 1px more round :) Acknowledged. I wasn't sure.
	5 <button type="submit">

	6 <img src="/img/png/search-icon.png" srcset="/img/svg/search-icon.svg 2x" alt ="{{ "Search" \| translate("search-icon-alt", "Image alt text") }}">

	7 </button>

	8 </form>

OLD	NEW

« includes/layout/header.tmpl ('K') | « includes/layout/header.tmpl ('k') | static/img/png/external-icon.png » ('j') | static/js/main.js » ('J')