includes/search-form.tmpl - Issue 29485575: Issue 5385 - Create Site Header Component for Help Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/search-form.tmpl

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)

Patch Set: Fix alignment of search form, reformat JS Created Aug. 22, 2017, 12:14 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <form id="search-form" action="https://duckduckgo.com" method="GET">

	2 <label for="search" class="sr-only">{{ "Search Adblock Plus Help" \| translate( "search-form-label", "Label") }}</label>
	juliandoucette 2017/08/23 14:39:04 Note: I don't know if "Label" is descriptive enoug Note: I don't know if "Label" is descriptive enough. My intuition says "Input Label", "Text box label", "Search form label". Because one might translate a label differently than a button label differently than an input label. But I don't actually know if that's true. ire 2017/08/25 08:27:07 I'm not sure if it's the case that they may be tra Show quoted text On 2017/08/23 14:39:04, juliandoucette wrote: > Note: I don't know if "Label" is descriptive enough. My intuition says "Input > Label", "Text box label", "Search form label". Because one might translate a > label differently than a button label differently than an input label. But I > don't actually know if that's true. I'm not sure if it's the case that they may be translated differently, but we don't lose anything being more specific. Done. juliandoucette 2017/08/29 16:17:23 Acknowledged. Show quoted text On 2017/08/25 08:27:07, ire wrote: > On 2017/08/23 14:39:04, juliandoucette wrote: > > Note: I don't know if "Label" is descriptive enough. My intuition says "Input > > Label", "Text box label", "Search form label". Because one might translate a > > label differently than a button label differently than an input label. But I > > don't actually know if that's true. > > I'm not sure if it's the case that they may be translated differently, but we > don't lose anything being more specific. > > Done. Acknowledged.
	3 <input id="search" name="q" type="search" placeholder="{{ "Search Adblock Plus Help" \| translate("search-form-label", "Label") }}">

	4 <input type="hidden" name="sites" value="adblockplus.org">

	5 <button type="submit">

	6 <img src="/img/png/search-icon.png" srcset="/img/svg/search-icon.svg 2x" alt ="{{ "Search" \| translate("search-icon-alt", "Image alt text") }}">

	7 </button>

	8 </form>

OLD	NEW

« includes/layout/header.tmpl ('K') | « includes/layout/header.tmpl ('k') | static/img/png/external-icon.png » ('j') | static/js/main.js » ('J')