static/js/main.js - Issue 29485575: Issue 5385 - Create Site Header Component for Help Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: static/js/main.js

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)

Patch Set: Fix alignment of search form, reformat JS Created Aug. 22, 2017, 12:14 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 (function(){

	2 document.addEventListener("DOMContentLoaded", function()

	3 {

	4

	5 // Change html class name from "no-js" to "js"

	6 document.documentElement.className = "js";

	7

	8 document
	juliandoucette 2017/08/23 14:39:04 If you agree with my comments elsewhere then I thi If you agree with my comments elsewhere then I think it logically follows to make this more generic so that we can re-use it on other websites. In that case, I suggest listening for a toggle button click on the body and toggeling that toggle button's parent or sibling toggle area. ire 2017/08/25 08:27:07 Done. Show quoted text On 2017/08/23 14:39:04, juliandoucette wrote: > If you agree with my comments elsewhere then I think it logically follows to > make this more generic so that we can re-use it on other websites. In that case, > I suggest listening for a toggle button click on the body and toggeling that > toggle button's parent or sibling toggle area. Done.
	9 .getElementById("toggle-search-form")

	10 .addEventListener("click", function(e) {

	11 e.preventDefault();

	12 document

	13 .getElementById("site-search")

	14 .classList.toggle("open");

	15 }, false);

	16

	17 }, false);

	18 }());

OLD	NEW