Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/scss/base/_variables.scss

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)
Left Patch Set: Fix svgs, Implement search, Show searchbar for no-js Created July 17, 2017, 9:24 a.m.
Right Patch Set: Include site variables before website-defaults Created Sept. 1, 2017, 12:11 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/scss/base/_utilities.scss ('k') | static/scss/components/_search-form.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 13 matching lines...) Expand all
24 $gray-medium: #AEAEAE; 24 $gray-medium: #AEAEAE;
25 $gray-dark: #757575; 25 $gray-dark: #757575;
26 $black: #161616; 26 $black: #161616;
27 27
28 // Brand colors 28 // Brand colors
29 29
30 $eyeo-black: $black; 30 $eyeo-black: $black;
31 $abp-red: #C70D2B; 31 $abp-red: #C70D2B;
32 $abb-blue: #0D79C7; 32 $abb-blue: #0D79C7;
33 33
34 $primary: $eyeo-black;
35
34 // Typography ////////////////////////////////////////////////////////////////// 36 // Typography //////////////////////////////////////////////////////////////////
35 37
36 // Font stack 38 // Font stack
37 39
38 $primary-font: "Source Sans Pro", sans-serif; 40 $primary-font: "Source Sans Pro", sans-serif;
39 41
40 // Font colours 42 // Font colours
41 43
42 $font-color-default: $eyeo-black; 44 $font-color-default: $eyeo-black;
43 $font-color-link: $abb-blue; 45 $font-color-link: $abb-blue;
44 46
45 // Font sizes (headings) 47 // Font sizes (headings)
46 48
47 $font-size-h1: 3em; 49 $font-size-h1: 3em;
48 $font-size-h2: 2em; 50 $font-size-h2: 2em;
49 $font-size-h3: 1.4em; 51 $font-size-h3: 1.4em;
50 $font-size-h4: 1em; 52 $font-size-h4: 1em;
51 $font-size-h5: $font-size-h4; 53 $font-size-h5: $font-size-h4;
52 $font-size-h6: $font-size-h4; 54 $font-size-h6: $font-size-h4;
53 55
54 // Font sizes (general) 56 // Font sizes (general)
55 57
56 $small-font: 0.9em; 58 $small-font: 0.9em;
57 $xsmall-font: 0.8em; 59 $tiny-font: 0.8em;
juliandoucette 2017/07/19 18:03:34 NIT: "x" -> "extra" ... This one is hard for me to
ire 2017/07/21 10:23:27 I acknowledge that the x is hard to read. I think
juliandoucette 2017/07/24 21:08:07 Acknowledged.
58 60
59 // Font weights 61 // Font weights
60 62
61 $bold-weight: 700; 63 $bold-weight: 700;
62 64
63 // Sizes /////////////////////////////////////////////////////////////////////// 65 // Sizes ///////////////////////////////////////////////////////////////////////
64 66
65 // Container widths 67 // Container widths
66 68
67 $content-max-width: 90%; 69 $content-width: 960px;
juliandoucette 2017/07/19 18:03:34 It seems like we should support the same max conte
ire 2017/07/21 10:23:26 I assumed this is what the $dekstop-width was, whi
juliandoucette 2017/07/24 21:08:07 Why should we use a width percentage instead of ac
68 $content-width: $desktop-width; 70 $navbar-width: $content-width + 100px;
juliandoucette 2017/07/19 18:03:35 Note: This isn't currently being used.
ire 2017/07/21 10:23:27 Yes its for the main part of the page. The $navbar
juliandoucette 2017/07/24 21:08:08 Acknowledged.
69 $navbar-width: $desktop-width + 100px;
70 71
71 // Header & Footer 72 // Header & Footer
72 73
73 $site-header-height: 65px; 74 $site-header-height: 70px;
75 $site-header-content-line-height: 40px;
74 76
75 // Searchform 77 // Search form
76 78
77 $searchform-width: 320px; 79 $search-form-width: 320px;
juliandoucette 2017/07/19 18:03:35 NIT/Suggest: "search-" or "search-form" ... "searc
ire 2017/07/21 10:23:27 I think "searchform" is one of those names like "n
juliandoucette 2017/07/24 21:08:08 Acknowledged. I'm not familiar with this pattern
78 $searchform-height: 35px; 80 $search-form-height: 35px;
79 81
80 // Spacers ///////////////////////////////////////////////////////////////////// 82 // Spacers /////////////////////////////////////////////////////////////////////
83
84 $xl: 60px;
85 $lg: 30px;
86 $md: 15px;
87 $sm: 10px;
88 $xs: 5px;
81 89
82 // Columns ///////////////////////////////////////////////////////////////////// 90 // Columns /////////////////////////////////////////////////////////////////////
83 91
84 // Breakpoints ///////////////////////////////////////////////////////////////// 92 // Breakpoints /////////////////////////////////////////////////////////////////
85 93
86 $mobile-breakpoint: 544px; 94 $phablet-breakpoint: 576px;
juliandoucette 2017/07/19 18:03:35 Is the width provided by website-defaults wrong?
ire 2017/07/21 10:23:27 There is no $mobile-breakpoint variable in website
juliandoucette 2017/07/24 21:08:07 I did that on purpose so that we would develop mob
87 95
88 // Placeholders //////////////////////////////////////////////////////////////// 96 // Placeholders ////////////////////////////////////////////////////////////////
LEFTRIGHT

Powered by Google App Engine
This is Rietveld