Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/scss/layout/_navbar.scss

Issue 29485575: Issue 5385 - Create Site Header Component for Help Center (Closed)
Left Patch Set: Fix svgs, Implement search, Show searchbar for no-js Created July 17, 2017, 9:24 a.m.
Right Patch Set: Include site variables before website-defaults Created Sept. 1, 2017, 12:11 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/scss/layout/_header.scss ('k') | static/scss/main.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 // GNU General Public License for more details. 12 // GNU General Public License for more details.
13 // 13 //
14 // You should have received a copy of the GNU General Public License 14 // You should have received a copy of the GNU General Public License
15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>. 15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
16 16
17 .navbar 17 .navbar
18 { 18 {
19 padding-top: 12px; 19 padding-top: $md;
juliandoucette 2017/07/19 18:03:39 I suggest using em here so that this padding scale
ire 2017/07/21 10:23:31 This will interfere with the fixed height. However
juliandoucette 2017/07/24 21:08:10 Acknowledged. Good point.
20 padding-bottom: 12px; 20 padding-bottom: $md;
21 color: $white; 21 color: $white;
juliandoucette 2017/07/19 18:03:39 I think it makes sense to implement generic things
22 background-color: $black; 22 background-color: $black;
23 } 23 }
24 24
25 .navbar a 25 .navbar a
26 { 26 {
27 color: $white; 27 color: $white;
28 } 28 }
29 29
30 .navbar-wrapper 30 .navbar-wrapper
juliandoucette 2017/07/19 18:03:38 Why .navbar-wrapper and not a more generic .contai
ire 2017/07/21 10:23:31 Because this container is specific to the navbar o
juliandoucette 2017/07/24 21:08:10 What is specific about the navbar's container? Are
31 { 31 {
32 width: $navbar-width; 32 width: $navbar-width;
juliandoucette 2017/07/19 18:03:39 Where is this width specified? --- (I think it's
ire 2017/07/21 10:23:31 It isn't specified anywhere. I used the $dekstop-w
juliandoucette 2017/07/24 21:08:10 They look the same to me?
ire 2017/08/10 16:54:43 In this image (https://bytebucket.org/adblockplus/
ire 2017/08/16 14:41:26 I spoke with Jeen and she confirmed that the navba
33 max-width: $content-max-width; 33 max-width: 100%;
juliandoucette 2017/07/19 18:03:38 Where is this max-width specified? --- (And why
ire 2017/07/21 10:23:30 It isn't specified anywhere. (Are these values sup
juliandoucette 2017/07/24 21:08:10 On the one hand: yes On the other hand: that which
ire 2017/08/10 16:54:43 Agreed. I haven't been able to find any objective
ire 2017/08/16 14:41:26 Done.
34 margin-right: auto; 34 margin-right: auto;
35 margin-left: auto; 35 margin-left: auto;
36 padding-right: $md;
37 padding-left: $md;
36 } 38 }
39
40 // Navbar Collapse
41
42 .navbar-collapse
43 {
44 display: none;
45 clear: both;
46
47 &.open
48 {
49 display: block;
50 }
51
52 @media (min-width: $tablet-breakpoint)
53 {
54 display: block;
55 clear: none;
56 width: auto;
57 }
58 }
59
60 .no-js .navbar-collapse
61 {
62 display: block;
63 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld