Issue 5385 - Create Site Header Component for Help Center

static/scss/base/_utilities.scss

 // This file is part of help.eyeo.com.
 // Copyright (C) 2017 Eyeo GmbH
 //
 // help.eyeo.com is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // help.eyeo.com is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 25 matching lines @@
 
 // Clearfix ///////////////////////////////////////////////////////////////
 
 .clearfix:after
 {
   display: table;
   clear: both;
   content: "";
 }
 
 // Responsive ///////////////////////////////////////////////////////////////

[juliandoucette, 2017/08/29 16:17:23]

It may be worth proposing that we rename $size-breakpoint to $size-min-width
based on the miscommunications below.

 
 .mobile-only
 {
-  @media (min-width: $mobile-breakpoint)

[juliandoucette, 2017/08/23 14:39:05]

See comment
[here](https://codereview.adblockplus.org/29485575/diff/29523654/static/scss/base/_variables.scss#newcode92).

[ire, 2017/08/25 08:27:08]

Acknowledged.

[juliandoucette, 2017/08/29 16:17:24]

Note: This should be min-width $tablet-breakpoint or min-width:
$phablet-breakpoint if we keep the existing naming scheme.

[ire, 2017/09/01 10:57:18]

Done.

+  @media (min-width: $phablet-breakpoint)
   {
     display: none;
   }
 }
 
-.tablet-and-mobile-only

[juliandoucette, 2017/08/23 14:39:05]

The website-default grid considers anything less than $desktop-breakpoint to be
tablet.

Also see comment
[here](https://codereview.adblockplus.org/29485575/diff/29523654/static/scss/base/_variables.scss#newcode92)

The same applies below.

[ire, 2017/08/25 08:27:08]

Ack. See my reply on the quoted comment.

[juliandoucette, 2017/08/29 16:17:23]

On 2017/08/25 08:27:08, ire wrote:
Ack. See my reply on the quoted comment.

Note: This should be min-width: $desktop-breakpoint if we keep the existing
naming scheme.

[ire, 2017/09/01 10:57:17]

This is changed to .phablet-and-mobile-only, width min-width: $tablet-breakpoint

+.phablet-and-mobile-only
 {
   @media (min-width: $tablet-breakpoint)
   {
     display: none;
   }
 }
 
 .tablet-and-desktop-only
 {
-  @media (max-width: $mobile-breakpoint)
+  @media (max-width: $tablet-breakpoint - 1px)
   {
     display: none;
   }
 }
 
 .desktop-only

[juliandoucette, 2017/08/23 14:39:05]

The website-default grid considers anything more than $desktop-breakpoint to be
desktop.

[ire, 2017/08/25 08:27:09]

Ack. See my reply on the quoted comment.

[juliandoucette, 2017/08/29 16:17:24]

Note: This should be min-width: $desktop-breakpoint if we keep the existing
naming scheme.

[ire, 2017/09/01 10:57:17]

This is max-width: $desktop-breakpoint, because I'm using max-width instead so i
don't have to apply a display property other than none (we don't know what the
display property of the element this class is applied to should be)

[juliandoucette, 2017/09/01 11:43:44]

Acknowledged. But it should be $tablet-breakpoint - 1 (otherwise you will create
a 1px grey area).

[ire, 2017/09/01 12:12:03]

Done.

 {
-  @media (max-width: $tablet-breakpoint)
+  @media (max-width: $desktop-breakpoint - 1px)
   {
     display: none;
   }
 }
 
 // Unstyled ///////////////////////////////////////////////////////////////
 
 .unstyled
 {
   margin: 0;
   padding: 0;
   border: 0;
   background: none;
 }