Issue 5385 - Create Site Header Component for Help Center

static/scss/layout/_header.scss

 // This file is part of help.eyeo.com.
 // Copyright (C) 2017 Eyeo GmbH
 //
 // help.eyeo.com is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // help.eyeo.com is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
 
 #site-header
 {
   min-height: $site-header-height;
   font-size: $small-font;
   line-height: $site-header-content-line-height;
 }
 
-.site-title

[juliandoucette, 2017/08/23 14:39:08]

I think these properties seem navbar specific and this name seems site specific.
I get the impression that there will not be several #site-title's on a page.
Therefore I would suggest writing a more specific ID or a less/more specific
class e.g. #site-title or .navbar-header or .navbar-logo.

[ire, 2017/08/25 08:27:12]

Done.

+#site-title
 {
   float: left;
   margin-right: $xl;
 }
 
-.site-title img
+html[dir="rtl"] #site-title
 {
-  height: $lg - 5px;
-  vertical-align: middle;
-
-  @media (min-width: $tablet-breakpoint)
-  {
-    height: $lg;
-  }
+  float: right;
+  margin-right: 0;
+  margin-left: $xl;
 }
 
-#toggle-search-form
+#site-title img
+{
+  height: $lg;
+  vertical-align: middle;
+}
+
+.toggle-navbar-collapse
 {
   width: $site-header-content-line-height;
   float: right;
   line-height: $site-header-content-line-height;
   text-align: right;
   cursor: pointer;
 
   img
   {
     width: $md;
     vertical-align: middle;
   }
 }
 
-html[dir="rtl"]
+html[dir="rtl"] .toggle-navbar-collapse
 {
-  .site-title
-  {
-    float: right;
-    margin-right: 0;
-    margin-left: $xl;
-  }
-
-  #toggle-search-form
-  {
-    float: left;
-  }
+  float: left;
 }
 
-.no-js #toggle-search-form
+.no-js .toggle-navbar-collapse
 {
   display: none;
 }